Bug 114115 - powersave and kernel: XFS: unknown mount option [commit]
Summary: powersave and kernel: XFS: unknown mount option [commit]
Status: VERIFIED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Mobile Devices (show other bugs)
Version: Beta 3
Hardware: Other All
: P2 - High : Normal
Target Milestone: ---
Assignee: Holger Macht
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-30 13:22 UTC by Harald Koenig
Modified: 2007-06-05 10:01 UTC (History)
1 user (show)

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
patch for /usr/lib/powersave/scripts/set_disk_settings (761 bytes, application/octet-stream)
2005-08-30 13:25 UTC, Harald Koenig
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Koenig 2005-08-30 13:22:28 UTC
since I started playing with acpi and powersave I sometimes get the
following kernel message

        Aug 29 22:40:38 compaq kernel: XFS: unknown mount option [commit].
        Aug 29 22:41:36 compaq kernel: XFS: unknown mount option [commit].
        Aug 29 22:47:22 compaq kernel: XFS: unknown mount option [commit].
        Aug 30 11:15:27 compaq kernel: XFS: unknown mount option [commit].
        Aug 30 11:16:20 compaq kernel: XFS: unknown mount option [commit].
        Aug 30 11:17:11 compaq kernel: XFS: unknown mount option [commit].
        Aug 30 11:19:41 compaq kernel: XFS: unknown mount option [commit].

the time stamps do not relate to a suspend/resume cycle (last resume from ram
was on 10:37:06).

I don't use any commit mount options:

        harald:~ # grep hda /etc/fstab
        /dev/hda1       /boot   ext3    defaults,noatime 1 1
        /dev/hda2       swap    swap    defaults 0 1
        /dev/hda3       /       xfs     defaults 1 2

but it shows up in /etc/mtab but but in /proc/mounts:

        harald:~ # grep commit /proc/mounts  /etc/mtab
        /etc/mtab:/dev/hda1 /boot ext3 rw,noatime,commit=600 0 0


> What does grep -r commit /etc say? Perhaps some startup script dynamically 
> appends this option?

good question!  this pointed (ambomg _many_ others;) to
/etc/sysconfig/powersave/disk saying

        # shall we remount journaled filesystems with appropriate commit interval?
        # this is needed to get the disk to shutdown on ext3 and reiserfs.
        HD_DO_REMOUNTS="yes"

and
        grep HD_DO_REMOUNTS `rpm -ql powersave`

finally resulted in the following patch which seems a reasonable fix:

------------------------------------------------------------------------------- 
--- /usr/lib/powersave/scripts/set_disk_settings~       2005-08-23
02:33:36.000000000 +0200
+++ /usr/lib/powersave/scripts/set_disk_settings        2005-08-30
14:58:43.425440250 +0200
@@ -68,7 +68,7 @@
                             "ext3")     mount $DEV -t $FST $MP -o
remount,$OPTS,commit=$HD_MAX_AGE ;;
                             "reiserfs") [ "$HD_NOATIME" = "yes" ] &&
OPTS="$OPTS,noatime"
                                         mount $DEV -t $FST $MP -o
remount,$OPTS,commit=$HD_MAX_AGE ;;
-                            "xfs")      mount $DEV -t $FST $MP -o
remount,$OPTS,commit=$HD_MAX_AGE ;;
+                            "xfs")      mount $DEV -t $FST $MP -o remount,$OPTS ;;
                         esac
                     done < /etc/mtab
                 fi
------------------------------------------------------------------------------- 


> In any case the "commit" option is Ext3 only unknown to XFS. Hence the 
> messages.

what about reiserfs ?  man 8 mount doesn't mention "commit" option for reiserfs, 
so that line has to be changed too ??

final question(s):  

why did this message show up 4 times, and why did it take from 10:37 to 11:15
after resume from ram for the 1st XFS message ?  I'd expect that either the fs
gets remounted immediately after resume or not at all, but not mulpile times
after 42+ minutes.  from /var/log/messages  (only firewall msgs removed):

        Aug 30 09:24:44 compaq kernel: usb usb1: USB disconnect, address 1
        Aug 30 09:24:44 compaq kernel: uhci_hcd 0000:00:07.2: USB bus 1 deregistered
        Aug 30 09:24:44 compaq kernel: ACPI: PCI interrupt for device
0000:00:07.2 disabled
        Aug 30 10:37:06 compaq kernel: Stopping tasks:
======================================================================|
        Aug 30 10:37:06 compaq kernel: ACPI: PCI interrupt for device
0000:00:0b.1 disabled
        Aug 30 10:37:06 compaq kernel: ACPI: PCI interrupt for device
0000:00:0b.0 disabled
        Aug 30 10:37:06 compaq kernel: ACPI: PCI interrupt for device
0000:00:00.1 disabled
        Aug 30 10:37:06 compaq kernel:  hwsleep-0296 [04]
acpi_enter_sleep_state: Entering sleep state [S3]
        Aug 30 10:37:06 compaq kernel: Back to C!
        Aug 30 10:37:06 compaq kernel: ACPI: PCI Interrupt 0000:00:00.1[B] ->
Link [LNKB] -> GSI 11 (level, low) -> IRQ 11
        Aug 30 10:37:06 compaq kernel: PCI: Setting latency timer of device
0000:00:00.1 to 64
        Aug 30 10:37:06 compaq kernel: ACPI: PCI Interrupt 0000:00:0b.0[A] ->
Link [LNKA] -> GSI 11 (level, low) -> IRQ 11
        Aug 30 10:37:06 compaq kernel: ACPI: PCI Interrupt 0000:00:0b.1[B] ->
Link [LNKB] -> GSI 11 (level, low) -> IRQ 11
        Aug 30 10:37:06 compaq kernel: eth0: link down
        Aug 30 10:37:06 compaq kernel: Restarting tasks... done
        ...
        Aug 30 10:45:06 compaq kernel: eth0: link up, 100Mbps, full-duplex, lpa
0x41E1
        Aug 30 10:48:41 compaq [powersave]: WARNING (handleHWEventRequest:116)
Could not read from hwEvent fd: 6, error: Resource temporarily unavailable
        Aug 30 11:01:47 compaq [powersave]: WARNING (handleHWEventRequest:116)
Could not read from hwEvent fd: 6, error: Resource temporarily unavailable
        Aug 30 11:14:53 compaq [powersave]: WARNING (handleHWEventRequest:116)
Could not read from hwEvent fd: 6, error: Resource temporarily unavailable
        Aug 30 11:15:27 compaq kernel: XFS: unknown mount option [commit].
        Aug 30 11:16:20 compaq kernel: XFS: unknown mount option [commit].
        Aug 30 11:17:11 compaq kernel: XFS: unknown mount option [commit].
        Aug 30 11:19:41 compaq kernel: XFS: unknown mount option [commit].
        Aug 30 11:26:03 compaq [powersave]: WARNING (handleHWEventRequest:116)
Could not read from hwEvent fd: 6, error: Resource temporarily unavailable
Comment 1 Harald Koenig 2005-08-30 13:25:25 UTC
Created attachment 48165 [details]
patch for /usr/lib/powersave/scripts/set_disk_settings

likely, commit=... should be removed for reiserfs too ?
Comment 2 Holger Macht 2005-08-30 14:28:29 UTC
Sounds good! Also the removal of commit option for reiserfs.

But why does this error not appear when using reiserfs filesystem? Seife, any idea?
Comment 3 Forgotten User ZhJd0F0L3x 2005-08-30 16:24:09 UTC
No. it works with reiserfs and it changes the commit interval. I have seen it :-)
Probably the mount manpage is out of sync with the fs code.
I fixed this in CVS (the fix will not make it into beta4, but later)
Comment 4 Holger Macht 2005-08-31 10:13:45 UTC
Ok, thanks, closing the bug.