1143663 – AUDIT-FIND: obs-service-refresh-patches: calls into osc and quilt

Bug 1143663 - AUDIT-FIND: obs-service-refresh-patches: calls into osc and quilt

Summary: AUDIT-FIND: obs-service-refresh-patches: calls into osc and quilt

Status:	NEW

Alias:	None

Product:	SUSE Security Incidents
Classification:	Novell Products
Component:	Audits (show other bugs)
Version:	unspecified
Hardware:	Other Other

Priority:	P5 - None Severity: Normal
Target Milestone:	---
Assignee:	Adrian Schröter
QA Contact:	Security Team bot

URL:
Whiteboard:	not:osc
Keywords:

Depends on:
Blocks:	1119444
	Show dependency tree / graph

Clone This Bug

Reported:	2019-07-31 14:24 UTC by Malte Kraus
Modified:	2023-10-12 08:12 UTC (History)
CC List:	2 users (show)

See Also:
Found By:	---
Services Priority:
Business Priority:
Blocker:	---
Marketing QA Status:	---
IT Deployment:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Malte Kraus 2019-07-31 14:24:40 UTC

refresh_patches: runs 'osc' (I guess this would break if it were not run as root?) and 'quilt' (which can be made to write to anywhere in the filesystem)

Comment 1 Johannes Segitz 2020-11-25 07:42:42 UTC

The issue with quilt is also described here: 
https://www.openwall.com/lists/oss-security/2018/09/27/2

I think it's probably not really an option to recreate the logic that quilt provides. Then I would suggest that quilt is either sandboxed (see https://github.com/jsegitz/squilt) or the user is at least warned that this is not a risk-free operation (as most probably assume it is).

Also tracked in https://github.com/openSUSE/obs-service-refresh_patches/issues/8 for visibility