Bug 1145650 - btrfsprogs: do not recommend btrfsmaintenance
Summary: btrfsprogs: do not recommend btrfsmaintenance
Status: NEW
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: David Sterba
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-08-14 15:02 UTC by Ludwig Nussel
Modified: 2020-04-18 10:55 UTC (History)
7 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ludwig Nussel 2019-08-14 15:02:32 UTC 
In https://bugzilla.suse.com/show_bug.cgi?id=1063638#c73 it was suggested that btrfsmaintenance is not actually needed. Since those cron jobs/timers cause trouble on quite some systems we should not pull in btrfsmaintenance by default. Unfortunately btrfsprogs still pulls it in. Could you please remove the Recommends or change it to a Suggests?
Comment 1 Jean Delvare 2019-09-02 10:03:48 UTC 
Yes please. That would also solve (or at least alleviate) bug #1124823.
Comment 2 Frank Krüger 2019-10-10 20:57:58 UTC 
Btrfsprogs still has "Recommends btrfsmaintenance" (version 5.2.2 updated Sep 12).
Comment 3 Frank Krüger 2020-01-03 22:19:23 UTC 
The issue still exists in Leap 15.2 Build 547.2. Is there any chance to get rid of this annoying "feature" in due time?
Comment 4 Ludwig Nussel 2020-01-07 08:47:50 UTC 
David refused it: https://build.opensuse.org/request/show/697571

He is probably right that there was no proper discussion. The referenced Fate also doesn't give much insight. I guess the btrfs developers either do not use btrfs on a Desktop themselves or the problem of the annoying maintenance task only hits certain setups that the developers don't have (rotating disks maybe?). So they don't suffer therefore have no pressure to fix. Feel free to open the discussion in a public place so we maybe get some insight on the affected setups.
Comment 5 Karl Mistelberger 2020-03-19 14:55:24 UTC 
Trouble caused by btrfsmaintenance predominantly comes from starting btrfsmaintenance-refresh.path before local-fs.target is reached:

https://github.com/kdave/btrfsmaintenance/issues/78
Comment 6 Karl Mistelberger 2020-04-18 07:03:39 UTC 
There is a bug in btrfsmaintenance-refresh.path triggering btrfsmaintenance-refresh.service for no good reason. Fixing this bug btrfsmaintenance tools are quite unobtrusive without making further modifications: btrfsmaintenance-refresh.path starts up in no time and watches for changes of /etc/sysconfig/btrfsmaintenance which does not take a noticeable fraction of a second.

The fix is easy: Make *absolutely* sure btrfsmaintenance-refresh.path starts after local-fs.target is reached. Don't rely on defaults. They may change with versions of systemd, programmers changing their mind or making mistakes, phases of the moon ...

https://github.com/kdave/btrfsmaintenance/pull/79