First Last Prev Next    This bug is not in your last search results.
Bug 1151186 - Changes to preferences not saved in Thunderbird's CardBook add-on
Changes to preferences not saved in Thunderbird's CardBook add-on
Status: RESOLVED FIXED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Firefox
Current
Other Other
: P5 - None : Normal (vote)
: ---
Assigned To: E-mail List
E-mail List
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2019-09-18 11:51 UTC by Tristan Miller
Modified: 2020-04-05 18:10 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tristan Miller 2019-09-18 11:51:06 UTC 
I am using the CardBook add-on for Thunderbird and am running up against a problem that occurs only with the Thunderbird from the openSUSE RPMs, not from the official Thunderbird binary downloaded from thunderbird.net.  So I think the problem must lie with whatever patches are being applied to the openSUSE RPMs.

The problem is that changes to the CardBook preferences do not persist.

Steps to reproduce:

0. If necessary, first install the CardBook add-on from <https://addons.thunderbird.net/addon/cardbook/>.
1. Open the CardBook tab (Tools->CardBook) and press the Preferences button to bring up the CardBook Preferences tab.
2. Change some of the preferences.  (For example, try enabling the Debug log.)
3. Close the CardBook Preferences tab.
4. In the CardBook tab, press the Preferences button to bring up the CardBook Preferences tab.

Observed behaviour:

5. The preferences have reverted to their previous state.

Expected behaviour:

5. The changes made to the preferences in Step 2 should have persisted.

I am using Thunderbird 68.1.0 (MozillaThunderbird-68.1.0-6.1.x86_64) and CardDav 42.0 on openSUSE Tumbleweed.  The problem is not reproducible when using the same version of Thunderbird downloaded from thunderbird.net.
Comment 1 Tristan Miller 2019-09-18 11:52:09 UTC 
Upstream bug report: https://gitlab.com/CardBook/CardBook/issues/699
Comment 2 Tristan Miller 2019-09-24 13:22:55 UTC 
After some further testing, I have isolated the problem to the file kde.js, which is included by mozilla-kde.patch. This patch was introduced as a result of Bug 170055.  The file kde.js contains the following single line:

pref("browser.preferences.instantApply", false);

If I comment this out and rebuild the RPM, then CardBook preferences get saved as expected.

Given that Thunderbird recently redesigned its preferences interface (I think in Thunderbird 68), is this kde.js still necessary?  If so, can the patch be modified in some way that doesn't break add-ons like CardBook?
Comment 3 Tristan Miller 2019-09-24 14:40:04 UTC 
The issue has now been fixed (or at least worked around) in CardBook itself by doing a Preferences.forceEnableInstantApply();.

Still, it would be nice to know whether openSUSE still needs to be manually changing the instantApply preference in the patch, particularly in light of Thunderbird's new preferences UI.  It could be that other add-ons are affected by the same problem when running on the Thunderbird installed from openSUSE RPMs.
Comment 4 Wolfgang Rosenauer 2019-09-24 14:50:13 UTC 
The kde.js stuff can go away as with the move to preferences in html tabs it completely changed the UX so there is no reason to keep the KDE UX.
Already removed in my WIP version but I need to do more (different) changes before it's ending up in Tumbleweed.
Comment 5 Swamp Workflow Management 2019-09-26 19:40:06 UTC 
This is an autogenerated message for OBS integration:
This bug (1151186) was mentioned in
https://build.opensuse.org/request/show/733508 Factory / MozillaThunderbird
Comment 6 Wolfgang Rosenauer 2019-09-26 21:08:17 UTC 
submitted fix
Comment 7 Tristan Miller 2019-09-27 07:08:44 UTC 
Thanks for attending to this so quickly!
Comment 8 Swamp Workflow Management 2019-10-04 13:10:12 UTC 
This is an autogenerated message for OBS integration:
This bug (1151186) was mentioned in
https://build.opensuse.org/request/show/735118 Factory / MozillaFirefox
Comment 11 Swamp Workflow Management 2019-10-15 16:12:45 UTC 
SUSE-RU-2019:2670-1: An update that has three recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1151186,1153423,1153869
CVE References: 
Sources used:
SUSE OpenStack Cloud Crowbar 8 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE OpenStack Cloud 8 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE OpenStack Cloud 7 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Software Development Kit 12-SP5 (src):    MozillaFirefox-68.1.0-109.92.1
SUSE Linux Enterprise Software Development Kit 12-SP4 (src):    MozillaFirefox-68.1.0-109.92.1
SUSE Linux Enterprise Server for SAP 12-SP3 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Server for SAP 12-SP2 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Server for SAP 12-SP1 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Server 12-SP5 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Server 12-SP4 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Server 12-SP3-LTSS (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Server 12-SP3-BCL (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Server 12-SP2-LTSS (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Server 12-SP2-BCL (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Server 12-SP1-LTSS (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Desktop 12-SP5 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Linux Enterprise Desktop 12-SP4 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Enterprise Storage 5 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
SUSE Enterprise Storage 4 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1
HPE Helion Openstack 8 (src):    MozillaFirefox-68.1.0-109.92.1, MozillaFirefox-branding-SLE-68-32.13.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 17 Swamp Workflow Management 2019-10-31 11:23:28 UTC 
SUSE-SU-2019:2871-1: An update that fixes 9 vulnerabilities is now available.

Category: security (important)
Bug References: 1104841,1129528,1137990,1149429,1151186,1153423,1153869,1154738
CVE References: CVE-2019-11757,CVE-2019-11758,CVE-2019-11759,CVE-2019-11760,CVE-2019-11761,CVE-2019-11762,CVE-2019-11763,CVE-2019-11764,CVE-2019-15903
Sources used:
SUSE Linux Enterprise Module for Open Buildservice Development Tools 15-SP1 (src):    MozillaFirefox-68.2.0-3.59.1
SUSE Linux Enterprise Module for Open Buildservice Development Tools 15 (src):    MozillaFirefox-68.2.0-3.59.1
SUSE Linux Enterprise Module for Desktop Applications 15-SP1 (src):    MozillaFirefox-68.2.0-3.59.1, MozillaFirefox-branding-SLE-68-4.11.2
SUSE Linux Enterprise Module for Desktop Applications 15 (src):    MozillaFirefox-68.2.0-3.59.1, MozillaFirefox-branding-SLE-68-4.11.2

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 19 Swamp Workflow Management 2019-11-07 14:15:10 UTC 
SUSE-SU-2019:2912-1: An update that fixes 9 vulnerabilities is now available.

Category: security (important)
Bug References: 1149126,1149429,1151186,1152778,1153879,1154738
CVE References: CVE-2019-11757,CVE-2019-11758,CVE-2019-11759,CVE-2019-11760,CVE-2019-11761,CVE-2019-11762,CVE-2019-11763,CVE-2019-11764,CVE-2019-15903
Sources used:
SUSE Linux Enterprise Workstation Extension 15-SP1 (src):    MozillaThunderbird-68.2.1-3.58.1
SUSE Linux Enterprise Workstation Extension 15 (src):    MozillaThunderbird-68.2.1-3.58.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.
Comment 20 Swamp Workflow Management 2019-11-09 17:16:25 UTC 
openSUSE-SU-2019:2451-1: An update that fixes 9 vulnerabilities is now available.

Category: security (important)
Bug References: 1104841,1129528,1137990,1149429,1151186,1153423,1153869,1154738
CVE References: CVE-2019-11757,CVE-2019-11758,CVE-2019-11759,CVE-2019-11760,CVE-2019-11761,CVE-2019-11762,CVE-2019-11763,CVE-2019-11764,CVE-2019-15903
Sources used:
openSUSE Leap 15.1 (src):    MozillaFirefox-68.2.0-lp151.2.18.2, MozillaFirefox-branding-openSUSE-68-lp151.3.3.1, firefox-esr-branding-openSUSE-68-lp151.3.3.1
Comment 21 Swamp Workflow Management 2019-11-09 17:17:43 UTC 
openSUSE-SU-2019:2459-1: An update that fixes 9 vulnerabilities is now available.

Category: security (important)
Bug References: 1104841,1129528,1137990,1149429,1151186,1153423,1153869,1154738
CVE References: CVE-2019-11757,CVE-2019-11758,CVE-2019-11759,CVE-2019-11760,CVE-2019-11761,CVE-2019-11762,CVE-2019-11763,CVE-2019-11764,CVE-2019-15903
Sources used:
openSUSE Leap 15.0 (src):    MozillaFirefox-68.2.0-lp150.3.71.1, MozillaFirefox-branding-openSUSE-68-lp150.3.3.1, firefox-esr-branding-openSUSE-68-lp150.3.3.1
Comment 22 Swamp Workflow Management 2019-11-09 17:19:34 UTC 
openSUSE-SU-2019:2452-1: An update that fixes 9 vulnerabilities is now available.

Category: security (important)
Bug References: 1149126,1149429,1151186,1152778,1153879,1154738
CVE References: CVE-2019-11757,CVE-2019-11758,CVE-2019-11759,CVE-2019-11760,CVE-2019-11761,CVE-2019-11762,CVE-2019-11763,CVE-2019-11764,CVE-2019-15903
Sources used:
openSUSE Leap 15.1 (src):    MozillaThunderbird-68.2.1-lp151.2.16.1
Comment 23 Swamp Workflow Management 2019-11-09 17:20:42 UTC 
openSUSE-SU-2019:2464-1: An update that fixes 9 vulnerabilities is now available.

Category: security (important)
Bug References: 1149126,1149429,1151186,1152778,1153879,1154738
CVE References: CVE-2019-11757,CVE-2019-11758,CVE-2019-11759,CVE-2019-11760,CVE-2019-11761,CVE-2019-11762,CVE-2019-11763,CVE-2019-11764,CVE-2019-15903
Sources used:
openSUSE Leap 15.0 (src):    MozillaThunderbird-68.2.1-lp150.3.54.1
First Last Prev Next    This bug is not in your last search results.