Bugzilla – Bug 115407
powersaved: rcpowersaved grab acpi kernel interface if acpid is not running
Last modified: 2007-06-05 10:01:15 UTC
If acpid is not running and you restart/start powersave with rcpowersaved the powersave is started without -f acpid_socket and grap the acpi kernelinterface from proc.
I will care about...
what is the problem? acpid is mandatory for powersaved on SUSE 10.0 now, so if you did not start acpid, you have a problem. So what? We could make it complain a bit louder, but BLOCKER? i don't think so.
Oh I did not notice severity... This is definitely no blocker. Because by default, acpid is running. But powersaved should not start without -f parameter in our rcscript if acpid is not running. Despite of this, is is a major problem because too many services (hal, ial) need the proc interface.
Hmmm, while thinking more about it. We already throw a warning to /var/log/messages/ in that case: rcpowersaved: WARN: Accessing /proc/acpi/events directly, better start acpid before powersaved But on console it simply sais: loading ACPI modules () done Starting powersaved (directly accessing /proc/acpi/events) done Maybe it would be enough to also print the "acpid-start-hint" on console. I think this should be enough. Seife, Thomas? Do you agree?
Why not. Do whatever you want with it. For me it's already enough. Unfortunately we cannot let depend the service hard on acpid, because we still have apm systems, so this should be sufficient. If you get all done in one line (with a normal/small resolution), then give a hint too if you like. Another option would be skipping, then hal would still run, but powersave daemon can never run standalone anymore... I'd go for your solution Holger.
If the system is ACPI, then complain loud: ############################################### # ACPI system but acpid not running. # # start acpid first, then restart powersaved! # ############################################### ...starting powersaved despite missing acpid If the system is APM, well, we are in another codepath and this warning will not be thrown anyway.
(In reply to comment #6) > If the system is ACPI, then complain loud: > > ############################################### > # ACPI system but acpid not running. # > # start acpid first, then restart powersaved! # > ############################################### > ...starting powersaved despite missing acpid exiting here is also fine with me: we warned loud enough :-)
I did it like mentioned in comment #6. So we do not have to remove all code regarding module loading and checking of processes which access /proc/acpi/event. I think this way we stay more compatible with systems where acpid or even hal is not used.
As discussed with danny once again, we will go the other way like in comment #7.
Finally, we never access /proc/acpi/event directly when called from rc script.