Bug 1165158 - openssh: several patches are of dubious use or snake oil
Summary: openssh: several patches are of dubious use or snake oil
Status: NEW
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Current
Hardware: All Other
: P5 - None : Enhancement (vote)
Target Milestone: ---
Assignee: Hans Petter Jansson
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-27 13:22 UTC by Cristian Rodríguez
Modified: 2023-05-30 10:42 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Cristian Rodríguez 2020-02-27 13:22:17 UTC
openssh ships a number of patches, some of dubious use

openssh-7.7p1-fips.patch, openssh-7.7p1-fips_checks.patch :openssl 1.1.x does not have a FIPS module, fips_mode() always returns false.the compiler does not know that fact and cannot optimize it out.


openssh-7.7p1-seed-prng.patch: always snake oil but now with the addition that in current linus tree /dev/urandom and /dev/random are backed by exactly the same code and the latter only blocks if the CRNG has not been initialised.
In most systems it will never block. 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=acd77500aa8a337baa6d853568c4b55aca48e20f
Also openssl 1.1.x uses a FIPS approved rng by default.
Comment 1 Hans Petter Jansson 2020-06-04 00:45:47 UTC
Thanks. I still need to establish what to do about the first one, but the RNG one will be dropped on the 8.3 update.
Comment 2 Cristian Rodríguez 2020-06-04 18:45:53 UTC
(In reply to Hans Petter Jansson from comment #1)
> Thanks. I still need to establish what to do about the first one, but the
> RNG one will be dropped on the 8.3 update.

It is my understanding that you will have to redo all of this since the FIPS provider in openSSL 3.x is a completely different beast.