Bug 1167866 - [Build 20200325] yast2 inst_release_notes: no rel notes shown
[Build 20200325] yast2 inst_release_notes: no rel notes shown
Status: CONFIRMED
Classification: openSUSE
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: YaST2
Current
Other Other
: P5 - None : Normal (vote)
: ---
Assigned To: YaST Team
Jiri Srain
https://openqa.opensuse.org/tests/121...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2020-03-27 09:26 UTC by Dominique Leuenberger
Modified: 2022-10-26 11:38 UTC (History)
4 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dominique Leuenberger 2020-03-27 09:26:48 UTC
## Observation

openQA test in scenario opensuse-Tumbleweed-DVD-x86_64-extra_tests_on_gnome@64bit fails in
[libqt5_qtbase](https://openqa.opensuse.org/tests/1215118/modules/libqt5_qtbase/steps/28)

https://build.opensuse.org/package/rdiff/openSUSE:Factory/yast2-installation?linkrev=base&rev=442

yast2-installation dropped the recommends on release-notes, which we consider wrong.

This package contains the inst_release_notes module to show the release notes and is thus the most logical place to also recommend the installation of said notes it wants to show to the user.


## Test suite description
Maintainer: asmorodskyi, okurz. Extra tests which were designed to run on gnome


## Reproducible

Fails since (at least) Build [20200309](https://openqa.opensuse.org/tests/1199785)


## Expected result

Last good: [20200307](https://openqa.opensuse.org/tests/1198559) (or more recent)


## Further details

Always latest result in this scenario: [latest](https://openqa.opensuse.org/tests/latest?arch=x86_64&distri=opensuse&flavor=DVD&machine=64bit&test=extra_tests_on_gnome&version=Tumbleweed)
Comment 1 Michal Filka 2020-05-12 08:04:57 UTC
@Josef:
AFAIK you removed the recommends directive (Recommends:     release-notes). Could you pls comment? Seems that something doesn't work as expected in https://github.com/yast/yast-installation/pull/845
Comment 2 Stefan Hundhammer 2020-06-16 09:40:53 UTC
Josef, this is still waiting for your input (for over one month now).
Comment 3 Josef Reidinger 2020-06-25 06:55:08 UTC
Well, release notes should be part of installation media. It is just recommend, so I expect that skelcd-openSUSE should require it. This way we ensure it will be there on installation medium and also that it was not installed when yast2-installation is needed on running system.
Comment 4 José Iván López González 2020-06-25 11:30:11 UTC
Added release-notes dependency in skelcd-control (as suggested by Josef), see [1, 2].

[1] https://github.com/yast/skelcd-control-openSUSE/pull/208

[2] https://build.opensuse.org/request/show/817044
Comment 5 Dominique Leuenberger 2020-06-25 11:42:43 UTC
(In reply to José Iván López González from comment #4)
> Added release-notes dependency in skelcd-control (as suggested by Josef),
> see [1, 2].
> 
> [1] https://github.com/yast/skelcd-control-openSUSE/pull/208
> 
> [2] https://build.opensuse.org/request/show/817044

That won't help (entirely) - the rel-notes during the installation can be shown as the rel notes seem to be grabbed from the web

what is not fine is that release notes on an INSTALLED system has nothing to show (again; imho, the tool knows it wants to show the rel notes, so it could just as well recommend the installation, i.e when running yast release notes on an installed system (arguably, this should remember that they are available onlinel just as the installer did)

skelcd-* is never installed on end-user systems (makes no sense on an installed system)


Issue shown on running system: 
  https://openqa.opensuse.org/tests/latest?arch=x86_64&distri=opensuse&flavor=DVD&machine=64bit&test=extra_tests_on_gnome&version=Tumbleweed#step/libqt5_qtbase/25

Issue not showing during installation (where skelcd could do anythin):
  https://openqa.opensuse.org/tests/1312278#step/installation_mode/1
we don't click the relnotes button, but the presence of the button implies that the relnotes could be found (before the online repo question, there is no relnotes shown)
Comment 6 Josef Reidinger 2020-06-25 12:31:57 UTC
Ah, now I get it. So it is quite tricky. Usual way in yast is not to do hard dependency, but install it on fly, when user want it like when configuring ftp server, it is installed on fly.
Comment 7 Dominique Leuenberger 2020-06-25 12:40:28 UTC
(In reply to Josef Reidinger from comment #6)
> Ah, now I get it. So it is quite tricky. Usual way in yast is not to do hard
> dependency, but install it on fly, when user want it like when configuring
> ftp server, it is installed on fly.

In this case, a Recommends seems still to be the most suitable thing; it can be removed by a user if he wishes, but zypp by default follows it (except on JeOS, Kubic, where recommends are off by default)

Al alternative could be to recommend the release notes by some base pattern, but it feels less logical there than in the app actually showing the notes (but not entire inacceptable)
Comment 8 Josef Reidinger 2020-06-25 14:12:48 UTC
(In reply to Dominique Leuenberger from comment #7)
> (In reply to Josef Reidinger from comment #6)
> > Ah, now I get it. So it is quite tricky. Usual way in yast is not to do hard
> > dependency, but install it on fly, when user want it like when configuring
> > ftp server, it is installed on fly.
> 
> In this case, a Recommends seems still to be the most suitable thing; it can
> be removed by a user if he wishes, but zypp by default follows it (except on
> JeOS, Kubic, where recommends are off by default)
> 
> Al alternative could be to recommend the release notes by some base pattern,
> but it feels less logical there than in the app actually showing the notes
> (but not entire inacceptable)

We discuss it on IRC and looks like the best solution is to follow usual yast convention and install package if user wants to see release notes. This way it will always work and keep system size small enough for other cases.
Comment 9 José Iván López González 2020-07-06 12:08:47 UTC
IIRC, it was decided to address this with a feature request in Jira. Am I right? Does this worth a feature request?
Comment 10 Ancor Gonzalez Sosa 2021-03-11 15:27:49 UTC
(In reply to José Iván López González from comment #9)
> 
> IIRC, it was decided to address this with a feature request in Jira. Am I
> right? Does this worth a feature request?

Which, as far as I can see, never happened. And, as a result, this bug report has been overlooked for quite some time. It's not queued in the YaST Team's Trello. And, to be honest, the current Jira workflow has proven to not be the quickest way to get something implemented.

If I got it correctly, what we want to implement is that the YaST client that shows the Release Notes, when executed in an already installed system, checks first that the release notes are available and asks the user to install the package is that's not the case.

I don't think we need to go through the whole Jira process for that. I will know create a Trello card to queue this in our list of tasks. If anyone disagrees, feel free to speak up.
Comment 12 Dominique Leuenberger 2022-10-26 11:38:42 UTC
Seems there is a stale NEEDINFO on me - but comment#10 indicates this should be on track