Bug 117193 - luit sometimes hangs
Summary: luit sometimes hangs
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: X11 Applications (show other bugs)
Version: RC 4
Hardware: Other All
: P2 - High : Normal
Target Milestone: ---
Assignee: Stefan Dirsch
QA Contact: Stefan Dirsch
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-15 10:42 UTC by Mike Fabian
Modified: 2013-01-17 11:05 UTC (History)
6 users (show)

See Also:
Found By: Development
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
strace of hanging 'luit -x mutt' (10.54 KB, text/plain)
2005-09-15 10:50 UTC, Michael Andres 		Details
p_bugzilla-117193-luit-sometimes-hangs.diff (2.27 KB, patch)
2005-09-28 15:42 UTC, Mike Fabian 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Fabian 2005-09-15 10:42:03 UTC 
Bug found by Michael Andres:

luit sometimes hangs. Example:

mfabian@rossini:~$ for i in 1 2 3 4 5 6 7 8 9 0 ; do echo $i; luit -x echo; done
1

2

[... hangs here ...]
Comment 1 Michael Andres 2005-09-15 10:50:57 UTC 
Created attachment 50010 [details]
strace of hanging 'luit -x mutt'
Comment 2 Mike Fabian 2005-09-28 15:42:26 UTC 
Created attachment 51058 [details]
p_bugzilla-117193-luit-sometimes-hangs.diff

Patch which seems to solve the problem for me.
Comment 3 Mike Fabian 2005-09-28 15:46:25 UTC 
If I understand it right, pty setup stuff like

    copyTermios(0, pty);

should be called *before* forking, otherwise the program
started in the child part with "execvp()" may already
try to write on the pty before the setup is finished.

I'm not sure about the signal-handlers. But probably
it cannot hurt to do this before the for as well.
Comment 4 Juliusz Chroboczek 2005-09-28 18:18:26 UTC 
Looks fine to me.
Comment 5 Stefan Dirsch 2005-09-28 19:56:52 UTC 
fixed for 10.1 Alpha2.