Bug 118199 - hwup and hwdown exit successfully if module is not found
Summary: hwup and hwdown exit successfully if module is not found
Status: VERIFIED FIXED
Alias: None
Product: SUSE Linux 10.1
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: unspecified
Hardware: Other All
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Christian Zoz
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 102541
  Show dependency tree / graph
 
Reported: 2005-09-21 11:12 UTC by Martin Vidner
Modified: 2007-06-05 09:37 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Vidner 2005-09-21 11:12:53 UTC 
hwup and hwdown report errors if they do not find the module to load/unload,  
that's fine. But the exit code should not be zero. This prevents yast from 
reporting the problem (bug 102541). 
  
Found on SLES9 SP2 and SL10 Beta 2.  
 
medusa:/etc/sysconfig/hardware # hwdown hwcfg-bus-pci-0000\:00\:0b.0new 
FATAL: Module tulipan not found. 
ERROR: Could not unload module 'tulipan' for device 
'hwcfg-bus-pci-0000:00:0b.0new' 
medusa:/etc/sysconfig/hardware # echo $? 
0 
medusa:/etc/sysconfig/hardware # hwup hwcfg-bus-pci-0000\:00\:0b.0new 
hwup: Loading module 'tulipan'  for device 'hwcfg-bus-pci-0000:00:0b.0new' 
FATAL: Module tulipan not found. 
medusa:/etc/sysconfig/hardware # echo $? 
0
Comment 1 Christian Zoz 2005-09-23 14:19:58 UTC 
In NLD (SLES9 and up to 9.3) hwup is also called from pci.agent. And if hwup
returned there with !=0 pci.agent will proceed in looking for a matching module
and will load that. So with return value == 0 we have no module loaded at
boottime and with return value != 0 we might end up with a wrong module. In the
second case you won't probably notice the broken hwcfg-file. So i wont fix that
for older releases.

Since 10.0 we don't have pci.agent anymore and hwup is always called directly.
So i will fix that for upcoming releases.
Comment 2 Lars Müller 2005-10-28 14:28:25 UTC 
Christian: You might have assigned this bug by accident to samba-maintainers.
Comment 3 Christian Zoz 2005-12-08 14:38:03 UTC 
Stefan Scheler (trainee) is currently working on hwup and will fix this.
Comment 4 Christian Zoz 2005-12-19 16:16:38 UTC 
hwup will now return != 0 if modprobe did not succeed.