Bugzilla – Bug 118255
minor polishing ideas for xdm/Xsetup
Last modified: 2005-09-28 19:56:01 UTC
Hi, I was just trying to integrated something in the X startup. So I was reading through /etc/X11/xdm/Xsetup and found some little things that you might want to polish, although they are not important at all. There is a little typo "fot": 161 # No xconsole fot kdm/gdm case 162 # 163 if test "$kdm" = "yes" -o "$gdm" = "yes" ; then 164 exit 0 165 fi In all other places the "=" are idented to the same column: 69 gnome2root=/opt/gnome/bin 70 gdmpid=/var/run/gdm.pid 71 gdm=no I thoght the for loop is a little bit confusing, because there is just one element: 61 for p in ${kde3root}/kdm 62 do 63 test -x $p && /sbin/checkproc -p $kdmpid $p &> /dev/null && kdm=yes 64 done Just thought these are some things to make a release of even higher quality. Felix P.S. Do you want to see such reports or are these things of too low interest? I could provide some more...
fixed for 10.1 Alpha2.