Bug 118281 - Banshee crashes when dealing with iTunes 5/iTunesDB 14 iPods
Summary: Banshee crashes when dealing with iTunes 5/iTunesDB 14 iPods
Status: VERIFIED FIXED
: 130275 (view as bug list)
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: GNOME (show other bugs)
Version: RC 1
Hardware: All All
: P5 - None : Critical
Target Milestone: ---
Assignee: Gary Ekker
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-21 20:09 UTC by Aaron Bockover
Modified: 2005-11-03 09:51 UTC (History)
1 user (show)

See Also:
Found By: Development
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
libipoddevice: iPod Nano Device Support (5.92 KB, patch)
2005-09-21 20:10 UTC, Aaron Bockover
Details | Diff
ipod-sharp: iTunesDB 14 support (iTunes 5 compatibility) (17.64 KB, patch)
2005-09-21 20:12 UTC, Aaron Bockover
Details | Diff
ipod-sharp: iTunesDB 14 support (iTunes 5 compatibility) (13.83 KB, patch)
2005-09-21 20:55 UTC, Aaron Bockover
Details | Diff
libipoddevice patch (4.81 KB, patch)
2005-10-12 22:11 UTC, Aaron Bockover
Details | Diff
ipod-sharp patch (9.18 KB, patch)
2005-10-12 22:12 UTC, Aaron Bockover
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Bockover 2005-09-21 20:09:36 UTC
Banshee will throw a DatabaseReadException if an iPod with a version 14 iTunesDB
database is plugged in. The libipoddevice (0.3.2) and ipod-sharp (0.5.4)
shipping with SuSE 10 currently do not support the new iPod Nano or version 14
iTunesDB at all.

Any Banshee user who has an iPod and uses iTunes who upgrades to iTunes 5 and
then tries the iPod with Banshee again will experience this crash. 

Most iTunes users are expected to upgrade to iTunes 5, thus this problem will
only increase in frequency.
Comment 1 Aaron Bockover 2005-09-21 20:10:45 UTC
Created attachment 50562 [details]
libipoddevice: iPod Nano Device Support

Patches for libipoddevice to add iPod Nano device support, needed for
ipod-sharp.
Comment 2 Aaron Bockover 2005-09-21 20:12:40 UTC
Created attachment 50563 [details]
ipod-sharp: iTunesDB 14 support (iTunes 5 compatibility)

ipod-sharp patch to read and write iTunesDB version 14 (which iTunes 5 writes).


This patch fixes the crash and adds updated, and much saner database handling.

The ipod-sharp patch also writes iTunesDB 14 in such a way that iTunes 5 will
now correctly read the ipod-sharp written database, which was not the case with
iTunes DB 13 (ipod-sharp-0.5.4).
Comment 3 Aaron Bockover 2005-09-21 20:51:19 UTC
Comment on attachment 50563 [details]
ipod-sharp: iTunesDB 14 support (iTunes 5 compatibility)

** DO NOT USE **
Comment 4 Aaron Bockover 2005-09-21 20:55:47 UTC
Created attachment 50568 [details]
ipod-sharp: iTunesDB 14 support (iTunes 5 compatibility)

ipod-sharp patch to read and write iTunesDB version 14 (which iTunes 5 writes).


Same description from previous (now obsolete) patch applies here. The previous
is obsolete because the committed version from svn didn't seem to get pulled
down properly when I made the patch, so it had some local changes that
commented out progress reporting code.

This is the correct patch! My apologies!
Comment 5 Mark Gordon 2005-09-22 19:37:51 UTC
The iTunesDB update came at an unfortunate time in our release cycle.

If possible, we should release an update.
Comment 6 JP Rosevear 2005-09-22 20:22:21 UTC
That is why I asked Aaron to file this bug.
Comment 7 Andreas Jaeger 2005-09-26 08:19:46 UTC
Let's do an update next week...

  	 Maintenance-Tracker-2375
Comment 8 Gary Ekker 2005-09-28 19:40:27 UTC
Aaron, is it necessary to require libbipoddevice-0.3.3? If not please redo the
patch so that it doesn't add this new requirement. Otherwise we'll need approval
to release the newer libbipodevice. 

Currently 10.0 has ipod-sharp-0.5.4 and libipoddevice-0.3.2.
Comment 9 Aaron Bockover 2005-10-12 22:10:21 UTC
I have re-done the patches to take only source code into account, and nothing
from the build scripts. Also, since Apple announced iTunes 6/DB15 today, these
updated patches allow us to work with that software too. 

I have been doing exhaustive tests on all iPods today with iTunes 6 and
ipod-sharp, and everything has been successful. It looks like Apple did not
actually change anything in the iTunesDB except for versioning.

The updated patches also allow for iPod Video device detection by just appending
the model table. No critical code was updated.
Comment 10 Aaron Bockover 2005-10-12 22:11:55 UTC
Created attachment 53898 [details]
libipoddevice patch

libipoddevice patch: iPod Nano/Video device detection support
Comment 11 Aaron Bockover 2005-10-12 22:12:54 UTC
Created attachment 53899 [details]
ipod-sharp patch

ipod-sharp update to suppport Nano/Video iPod and the iTunesDB version 15. Support for iTunes 6.
Comment 12 Aaron Bockover 2005-10-12 22:14:36 UTC
Also note these last two patches obsolete all prior patches, and for application
against SL10-packaged libipoddevice 0.3.2 and ipod-sharp 0.5.4.
Comment 13 JP Rosevear 2005-10-25 15:36:20 UTC
*** Bug 130275 has been marked as a duplicate of this bug. ***
Comment 14 Michael Schröder 2005-10-31 14:34:45 UTC
The patchinfo contains a lot of "banshee" packages. Why are they needed, I only see fixed for ipod-sharp and libipoddevice.
Comment 15 Mark Gordon 2005-10-31 15:44:23 UTC
Banshee is using something akin to static linking with respect to ipod-sharp.  You'll notice that no package requires ipod-sharp or anything provided by it; it's soley a build dep.
Comment 16 Anja Stock 2005-11-03 09:47:45 UTC
released