Suspend does not work anymore. This is probably related.

The dmesg output is:

[ 1745.530531] PM: suspend entry (deep)
[ 1745.658232] Filesystems sync: 0.127 seconds
[ 1745.658680] Freezing user space processes ... 
[ 1765.663348] Freezing of tasks failed after 20.004 seconds (2 tasks refusing to freeze, wq_busy=0):
[ 1765.663372] task:systemd-udevd   state:D stack:    0 pid:  544 ppid:   535 flags:0x00004224
[ 1765.663383] Call Trace:
[ 1765.663391]  __schedule+0x2ee/0x950
[ 1765.663411]  schedule+0x46/0xb0
[ 1765.663424]  async_synchronize_cookie_domain+0x96/0x150
[ 1765.663434]  ? wait_woken+0x80/0x80
[ 1765.663449]  do_init_module+0x1fa/0x270
[ 1765.663459]  __do_sys_init_module+0x13b/0x1c0
[ 1765.663471]  do_syscall_64+0x33/0x80
[ 1765.663483]  entry_SYSCALL_64_after_hwframe+0x44/0xae
[ 1765.663493] RIP: 0033:0x7fa18cc9724e
[ 1765.663500] RSP: 002b:00007ffd2b5fba38 EFLAGS: 00000246 ORIG_RAX: 00000000000000af
[ 1765.663508] RAX: ffffffffffffffda RBX: 00005635c9e4f470 RCX: 00007fa18cc9724e
[ 1765.663514] RDX: 00007fa18cdb73a3 RSI: 000000000000da6b RDI: 00005635c9e5a010
[ 1765.663519] RBP: 00005635c9e5a010 R08: 00005635c9d68570 R09: 0000000000000003
[ 1765.663523] R10: 00005630aab84778 R11: 0000000000000246 R12: 00007fa18cdb73a3
[ 1765.663528] R13: 00005635c9e4d340 R14: 0000000000000000 R15: 00005635c9e50690
[ 1765.663538] task:systemd-udevd   state:D stack:    0 pid:  559 ppid:   535 flags:0x00004224
[ 1765.663546] Call Trace:
[ 1765.663550]  __schedule+0x2ee/0x950
[ 1765.663563]  schedule+0x46/0xb0
[ 1765.663574]  async_synchronize_cookie_domain+0x96/0x150
[ 1765.663581]  ? wait_woken+0x80/0x80
[ 1765.663592]  do_init_module+0x1fa/0x270
[ 1765.663601]  __do_sys_init_module+0x13b/0x1c0
[ 1765.663612]  do_syscall_64+0x33/0x80
[ 1765.663622]  entry_SYSCALL_64_after_hwframe+0x44/0xae
[ 1765.663630] RIP: 0033:0x7fa18cc9724e
[ 1765.663635] RSP: 002b:00007ffd2b5fba38 EFLAGS: 00000246 ORIG_RAX: 00000000000000af
[ 1765.663641] RAX: ffffffffffffffda RBX: 00005635c9e553b0 RCX: 00007fa18cc9724e
[ 1765.663646] RDX: 00007fa18cdb73a3 RSI: 0000000000018e33 RDI: 00005635ca675530
[ 1765.663650] RBP: 00005635ca675530 R08: 00005635c9e539c0 R09: 0000000000000003
[ 1765.663654] R10: 00005630aaba3623 R11: 0000000000000246 R12: 00007fa18cdb73a3
[ 1765.663658] R13: 00005635c9e6a900 R14: 0000000000000000 R15: 00005635c9d67370

[ 1765.663707] OOM killer enabled.
[ 1765.663709] Restarting tasks ... done.
[ 1765.666095] PM: suspend exit

Could you check whether the issue is still seen on the kernel in OBS Kernel:stable repo?  It looks rather like a bug in elants-i2c driver.

The most recent kernel gives the same error. Below the relevant dmesg output.

The elants_i2c driver is used for my touchscreen. This is now not working, while the driver is loaded.

> lsmod | grep elants
elants_i2c             32768  1


There was a change on this driver in this kernel version.
elants_i2c: add support for eKTF3624
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=9517b95bdc4699d94c2ffc6a520bb0ccec396f5b

This should not be a problem, adding support for an other driver. But perheps it is.



[    0.000000] Linux version 5.12.6-1.gfe25271-default (geeko@buildhost) (gcc (SUSE Linux) 10.3.0, GNU ld (GNU Binutils; openSUSE Tumbleweed) 2.36.1.20210326-4) #1 SMP Sat May 22 11:31:22 UTC 2021 (fe25271)
[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-5.12.6-1.gfe25271-default root=UUID=7c0eef22-6f76-4c30-a517-f2bd24ae08f1 resume=UUID=d9c405f4-7267-4901-beb1-0fb4f77c0dfa splash=silent quiet intel_pstate=enable mitigations=auto


[    7.296836] ------------[ cut here ]------------
[    7.296840] WARNING: CPU: 1 PID: 407 at arch/x86/include/asm/kfence.h:44 kfence_protect_page+0x31/0xa0
[    7.296850] Modules linked in: snd_timer snd elants_i2c fjes(-) tiny_power_button pcc_cpufreq(-) fan mei cros_kbd_led_backlight thermal dw_dmac soundcore button nls_iso8859_1 nls_cp437 vfat fat fuse configfs usbhid i915 hid_rmi rmi_core videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_common videodev mc xhci_pci xhci_pci_renesas i2c_algo_bit hid_generic xhci_hcd drm_kms_helper crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel syscopyarea sysfillrect sysimgblt fb_sys_fops cec rc_core crypto_simd drm cryptd usbcore serio_raw battery pinctrl_lynxpoint i2c_hid_acpi video i2c_hid btrfs blake2b_generic libcrc32c crc32c_intel xor raid6_pq sg dm_multipath dm_mod scsi_dh_rdac scsi_dh_emc scsi_dh_alua ecryptfs efivarfs
[    7.296937] CPU: 1 PID: 407 Comm: kworker/u8:4 Not tainted 5.12.6-1.gfe25271-default #1 openSUSE Tumbleweed (unreleased)
[    7.296942] Hardware name: GOOGLE Lulu/Lulu, BIOS MrChromebox-4.11.2 03/20/2020
[    7.296945] Workqueue: events_unbound async_run_entry_fn
[    7.296950] RIP: 0010:kfence_protect_page+0x31/0xa0
[    7.296956] Code: 48 83 ec 10 65 48 8b 04 25 28 00 00 00 48 89 44 24 08 31 c0 48 8d 74 24 04 e8 eb a5 db ff 48 85 c0 74 07 83 7c 24 04 01 74 06 <0f> 0b 31 c0 eb 39 48 8b 38 48 89 c2 84 db 75 46 48 89 f8 0f 1f 40
[    7.296959] RSP: 0018:ffffa97040743c00 EFLAGS: 00010046
[    7.296963] RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffffa97040743c04
[    7.296966] RDX: ffffa97040743c04 RSI: 0000000000000000 RDI: 0000000000000000
[    7.296968] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
[    7.296971] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
[    7.296973] R13: ffffa97040743cb8 R14: 0000000000000018 R15: 0000000000000000
[    7.296976] FS:  0000000000000000(0000) GS:ffff9caebac80000(0000) knlGS:0000000000000000
[    7.296979] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    7.296982] CR2: 0000000000000018 CR3: 0000000101d12004 CR4: 00000000003706e0
[    7.296985] Call Trace:
[    7.296990]  kfence_unprotect+0x13/0x30
[    7.296996]  page_fault_oops+0x9d/0x2b0
[    7.297001]  ? kobject_uevent_env+0x120/0x7c0
[    7.297007]  exc_page_fault+0x5d/0x120
[    7.297013]  asm_exc_page_fault+0x1e/0x30
[    7.297018] RIP: 0010:elants_i2c_probe+0xf2/0x4b0 [elants_i2c]
[    7.297028] Code: c0 e8 d2 44 e2 ee 48 c7 c2 40 aa cd c0 c7 85 90 00 00 00 00 00 00 00 48 8d bd 98 00 00 00 48 c7 c6 47 74 cd c0 e8 1e 85 e1 ee <49> 8b 45 18 48 89 5d 00 4c 89 e7 48 89 ab 98 00 00 00 48 c7 c6 50
[    7.297031] RSP: 0018:ffffa97040743d60 EFLAGS: 00010286
[    7.297034] RAX: ffff9caea36136b8 RBX: ffff9cae40c73c00 RCX: 0000000000000001
[    7.297037] RDX: ffffffffc0cdaa40 RSI: ffffffffc0cd7447 RDI: ffff9caea36136b0
[    7.297040] RBP: ffff9caea3613618 R08: ffffa97040743cf0 R09: ffff9caea3613600
[    7.297042] R10: ffffffffffffffff R11: 0000000000000000 R12: ffff9cae40c73c20
[    7.297045] R13: 0000000000000000 R14: ffff9caea5066930 R15: 0000000000000000
[    7.297050]  ? acpi_add_pm_notifier+0x49/0xd0
[    7.297056]  ? __cond_resched+0x16/0x40
[    7.297060]  ? mutex_lock+0xe/0x30
[    7.297063]  ? acpi_dev_pm_attach+0xe8/0x100
[    7.297069]  ? write_update_fw+0xd0/0xd0 [elants_i2c]
[    7.297075]  i2c_device_probe+0x1e5/0x270
[    7.297082]  really_probe+0xf2/0x440
[    7.297087]  driver_probe_device+0xe1/0x150
[    7.297092]  __driver_attach_async_helper+0xdd/0xf0
[    7.297097]  async_run_entry_fn+0x37/0x140
[    7.297101]  process_one_work+0x1df/0x370
[    7.297107]  worker_thread+0x50/0x400
[    7.297112]  ? process_one_work+0x370/0x370
[    7.297117]  kthread+0x11b/0x140
[    7.297122]  ? __kthread_bind_mask+0x60/0x60
[    7.297126]  ret_from_fork+0x22/0x30
[    7.297134] ---[ end trace 294b23dca3c68a73 ]---
[    7.297141] ------------[ cut here ]------------
[    7.297142] WARNING: CPU: 1 PID: 407 at mm/kfence/core.c:134 kfence_unprotect+0x18/0x30
[    7.297149] Modules linked in: snd_timer snd elants_i2c fjes(-) tiny_power_button pcc_cpufreq(-) fan mei cros_kbd_led_backlight thermal dw_dmac soundcore button nls_iso8859_1 nls_cp437 vfat fat fuse configfs usbhid i915 hid_rmi rmi_core videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_common videodev mc xhci_pci xhci_pci_renesas i2c_algo_bit hid_generic xhci_hcd drm_kms_helper crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel syscopyarea sysfillrect sysimgblt fb_sys_fops cec rc_core crypto_simd drm cryptd usbcore serio_raw battery pinctrl_lynxpoint i2c_hid_acpi video i2c_hid btrfs blake2b_generic libcrc32c crc32c_intel xor raid6_pq sg dm_multipath dm_mod scsi_dh_rdac scsi_dh_emc scsi_dh_alua ecryptfs efivarfs
[    7.297221] CPU: 1 PID: 407 Comm: kworker/u8:4 Tainted: G        W         5.12.6-1.gfe25271-default #1 openSUSE Tumbleweed (unreleased)
[    7.297225] Hardware name: GOOGLE Lulu/Lulu, BIOS MrChromebox-4.11.2 03/20/2020
[    7.297227] Workqueue: events_unbound async_run_entry_fn
[    7.297232] RIP: 0010:kfence_unprotect+0x18/0x30
[    7.297236] Code: 05 4c 91 9b 01 00 c3 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 81 e7 00 f0 ff ff 31 f6 e8 1d ff ff ff 84 c0 74 01 c3 <0f> 0b c6 05 1f 91 9b 01 00 c3 66 66 2e 0f 1f 84 00 00 00 00 00 0f
[    7.297240] RSP: 0018:ffffa97040743c28 EFLAGS: 00010046
[    7.297243] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
[    7.297246] RDX: ffffa97040743c04 RSI: 0000000000000000 RDI: 0000000000000000
[    7.297248] RBP: 0000000000000018 R08: 0000000000000000 R09: 0000000000000000
[    7.297250] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
[    7.297252] R13: ffffa97040743cb8 R14: 0000000000000018 R15: 0000000000000000
[    7.297255] FS:  0000000000000000(0000) GS:ffff9caebac80000(0000) knlGS:0000000000000000
[    7.297258] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    7.297261] CR2: 0000000000000018 CR3: 0000000101d12004 CR4: 00000000003706e0
[    7.297264] Call Trace:
[    7.297265]  page_fault_oops+0x9d/0x2b0
[    7.297270]  ? kobject_uevent_env+0x120/0x7c0
[    7.297275]  exc_page_fault+0x5d/0x120
[    7.297280]  asm_exc_page_fault+0x1e/0x30
[    7.297285] RIP: 0010:elants_i2c_probe+0xf2/0x4b0 [elants_i2c]
[    7.297292] Code: c0 e8 d2 44 e2 ee 48 c7 c2 40 aa cd c0 c7 85 90 00 00 00 00 00 00 00 48 8d bd 98 00 00 00 48 c7 c6 47 74 cd c0 e8 1e 85 e1 ee <49> 8b 45 18 48 89 5d 00 4c 89 e7 48 89 ab 98 00 00 00 48 c7 c6 50
[    7.297296] RSP: 0018:ffffa97040743d60 EFLAGS: 00010286
[    7.297299] RAX: ffff9caea36136b8 RBX: ffff9cae40c73c00 RCX: 0000000000000001
[    7.297301] RDX: ffffffffc0cdaa40 RSI: ffffffffc0cd7447 RDI: ffff9caea36136b0
[    7.297304] RBP: ffff9caea3613618 R08: ffffa97040743cf0 R09: ffff9caea3613600
[    7.297306] R10: ffffffffffffffff R11: 0000000000000000 R12: ffff9cae40c73c20
[    7.297309] R13: 0000000000000000 R14: ffff9caea5066930 R15: 0000000000000000
[    7.297314]  ? acpi_add_pm_notifier+0x49/0xd0
[    7.297319]  ? __cond_resched+0x16/0x40
[    7.297322]  ? mutex_lock+0xe/0x30
[    7.297326]  ? acpi_dev_pm_attach+0xe8/0x100
[    7.297331]  ? write_update_fw+0xd0/0xd0 [elants_i2c]
[    7.297338]  i2c_device_probe+0x1e5/0x270
[    7.297344]  really_probe+0xf2/0x440
[    7.297349]  driver_probe_device+0xe1/0x150
[    7.297353]  __driver_attach_async_helper+0xdd/0xf0
[    7.297358]  async_run_entry_fn+0x37/0x140
[    7.297362]  process_one_work+0x1df/0x370
[    7.297369]  worker_thread+0x50/0x400
[    7.297374]  ? process_one_work+0x370/0x370
[    7.297379]  kthread+0x11b/0x140
[    7.297384]  ? __kthread_bind_mask+0x60/0x60
[    7.297388]  ret_from_fork+0x22/0x30
[    7.297395] ---[ end trace 294b23dca3c68a74 ]---
[    7.297398] BUG: kernel NULL pointer dereference, address: 0000000000000018
[    7.297402] #PF: supervisor read access in kernel mode
[    7.297406] #PF: error_code(0x0000) - not-present page
[    7.297409] PGD 0 P4D 0 
[    7.297413] Oops: 0000 [#1] SMP PTI
[    7.297418] CPU: 1 PID: 407 Comm: kworker/u8:4 Tainted: G        W         5.12.6-1.gfe25271-default #1 openSUSE Tumbleweed (unreleased)
[    7.297423] Hardware name: GOOGLE Lulu/Lulu, BIOS MrChromebox-4.11.2 03/20/2020
[    7.297425] Workqueue: events_unbound async_run_entry_fn
[    7.297430] RIP: 0010:elants_i2c_probe+0xf2/0x4b0 [elants_i2c]
[    7.297438] Code: c0 e8 d2 44 e2 ee 48 c7 c2 40 aa cd c0 c7 85 90 00 00 00 00 00 00 00 48 8d bd 98 00 00 00 48 c7 c6 47 74 cd c0 e8 1e 85 e1 ee <49> 8b 45 18 48 89 5d 00 4c 89 e7 48 89 ab 98 00 00 00 48 c7 c6 50
[    7.297442] RSP: 0018:ffffa97040743d60 EFLAGS: 00010286
[    7.297446] RAX: ffff9caea36136b8 RBX: ffff9cae40c73c00 RCX: 0000000000000001
[    7.297449] RDX: ffffffffc0cdaa40 RSI: ffffffffc0cd7447 RDI: ffff9caea36136b0
[    7.297453] RBP: ffff9caea3613618 R08: ffffa97040743cf0 R09: ffff9caea3613600
[    7.297456] R10: ffffffffffffffff R11: 0000000000000000 R12: ffff9cae40c73c20
[    7.297459] R13: 0000000000000000 R14: ffff9caea5066930 R15: 0000000000000000
[    7.297462] FS:  0000000000000000(0000) GS:ffff9caebac80000(0000) knlGS:0000000000000000
[    7.297465] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    7.297469] CR2: 0000000000000018 CR3: 0000000101d12004 CR4: 00000000003706e0
[    7.297472] Call Trace:
[    7.297475]  ? acpi_add_pm_notifier+0x49/0xd0
[    7.297481]  ? __cond_resched+0x16/0x40
[    7.297485]  ? mutex_lock+0xe/0x30
[    7.297489]  ? acpi_dev_pm_attach+0xe8/0x100
[    7.297495]  ? write_update_fw+0xd0/0xd0 [elants_i2c]
[    7.297502]  i2c_device_probe+0x1e5/0x270
[    7.297509]  really_probe+0xf2/0x440
[    7.297515]  driver_probe_device+0xe1/0x150
[    7.297520]  __driver_attach_async_helper+0xdd/0xf0
[    7.297526]  async_run_entry_fn+0x37/0x140
[    7.297531]  process_one_work+0x1df/0x370
[    7.297537]  worker_thread+0x50/0x400
[    7.297543]  ? process_one_work+0x370/0x370
[    7.297548]  kthread+0x11b/0x140
[    7.297553]  ? __kthread_bind_mask+0x60/0x60
[    7.297559]  ret_from_fork+0x22/0x30
[    7.297566] Modules linked in: snd_timer snd elants_i2c fjes(-) tiny_power_button pcc_cpufreq(-) fan mei cros_kbd_led_backlight thermal dw_dmac soundcore button nls_iso8859_1 nls_cp437 vfat fat fuse configfs usbhid i915 hid_rmi rmi_core videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_common videodev mc xhci_pci xhci_pci_renesas i2c_algo_bit hid_generic xhci_hcd drm_kms_helper crct10dif_pclmul crc32_pclmul ghash_clmulni_intel aesni_intel syscopyarea sysfillrect sysimgblt fb_sys_fops cec rc_core crypto_simd drm cryptd usbcore serio_raw battery pinctrl_lynxpoint i2c_hid_acpi video i2c_hid btrfs blake2b_generic libcrc32c crc32c_intel xor raid6_pq sg dm_multipath dm_mod scsi_dh_rdac scsi_dh_emc scsi_dh_alua ecryptfs efivarfs
[    7.297644] CR2: 0000000000000018
[    7.297647] ---[ end trace 294b23dca3c68a75 ]---
[    7.297650] RIP: 0010:elants_i2c_probe+0xf2/0x4b0 [elants_i2c]

Thanks for testing.  I guess the commit is indeed the culprit; the buggy line is where retrieving id->driver_data, and this could be NULL.

I'm building a test kernel with the potential fix in OBS home:tiwai:bsc1186454 repo.  The package will be available later at
  http://download.opensuse.org/repositories/home:/tiwai:/bsc1186454/standard/

Please give it a try later.

Bingo, this solved the bug.
- touchscreen works again
- suspend works
- no bugs in dmesg

Thanks!


Just for verifing that i got the correct kernel, below the relevant dmesg output.


[    0.000000] Linux version 5.12.6-1.gf86c0d3-default (geeko@buildhost) (gcc (SUSE Linux) 11.1.1 20210510 [revision 23855a176609fe8dda6abaf2b21846b4517966eb], GNU ld (GNU Binutils; openSUSE Tumbleweed) 2.36.1.20210326-4) #1 SMP Wed May 26 14:54:25 UTC 2021 (f86c0d3)
[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-5.12.6-1.gf86c0d3-default root=UUID=7c0eef22-6f76-4c30-a517-f2bd24ae08f1 resume=UUID=d9c405f4-7267-4901-beb1-0fb4f77c0dfa splash=silent quiet intel_pstate=enable mitigations=auto

Good to hear.  I submitted the fix patch to the upstream, but the upstream suggested a slightly different way of the fix.

An updated test kernel is being rebuilt in the same OBS repo, home:tiwai:bsc1186454.  Could you retest later?  It should have *.gc9275aa release number.

The slightly different way of the fix, gives the same result:
- no errors in dmesg
- touchscreen works
- suspend works




Just for verifying the kernel version, below the relevant dmesg output.

> dmesg
[    0.000000] Linux version 5.12.7-1.gc9275aa-default (geeko@buildhost) (gcc (SUSE Linux) 11.1.1 20210510 [revision 23855a176609fe8dda6abaf2b21846b4517966eb], GNU ld (GNU Binutils; openSUSE Tumbleweed) 2.36.1.20210326-4) #1 SMP Thu May 27 07:07:13 UTC 2021 (c9275aa)
[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-5.12.7-1.gc9275aa-default root=UUID=7c0eef22-6f76-4c30-a517-f2bd24ae08f1 resume=UUID=d9c405f4-7267-4901-beb1-0fb4f77c0dfa splash=silent quiet intel_pstate=enable mitigations=auto

The fix went into TW.  Let's close.