Bugzilla – Bug 118797
libgnomeprint instability
Last modified: 2005-11-03 09:58:48 UTC
2.12.0 had some significant problems that have been patched in 2.12.1 and libgnomecups 0.2.2 - print preview would crash - rendering images would crash - printing to an invalid (eg no permission) would crash. - 1-2k / hr was leaked with an additional 100k per print command. - Some apps lost a page in the print dialog http://bugzilla.gnome.org/show_bug.cgi?id=316490 http://bugzilla.gnome.org/show_bug.cgi?id=316018 http://bugzilla.gnome.org/show_bug.cgi?id=312803 http://bugzilla.gnome.org/show_bug.cgi?id=312928 http://bugzilla.gnome.org/show_bug.cgi?id=312929 http://bugzilla.gnome.org/show_bug.cgi?id=316517
AJ, we need a swamp ID for this. Can we just ship the new version or should we diff 2.12.1/2.12.0 and ship a big patch?
Please do a diff and check that the ABI and API does not change. If there are ABI changes, only backport the fixes. Otherwise ok to update to 2.12.1. SWAMP-ID: Maintenance-Tracker-2390
Jody can you guarantee no ABI/API changes? tardiff tells me 48386 lines of diff for libgnomeprint, not sure I want to inspect that for changes. libgnomecups looks fine in this regard.
Most of that diff is likely .po files. There were two api/abi changes in private functions used only by libgnomeprint. gp-gc-private.h:void gp_gc_set_user_data (GPGC *gc, GObject *user_data); gp-gc-private.h:GObject *gp_gc_get_user_data (GPGC const *gc); were renamed from gp_gc_get_data, gp_gc_set_data and their argument was changed from gpointer -> GObject. I do not see gp-gc-private.h being included by anything in gnome.
I submitted these updates.
released
well, this does not look too good: 22 failures caused by this change: abiword:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' anjuta:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' balsa:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' conglomerate:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' eog:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' epiphany:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' evince:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' evolution:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' evolution-exchange:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' gal2:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' gedit:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' ghex:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' glabels:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' gnome-utils:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' gnumeric:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' gnumeric:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' gnumeric:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' gthumb:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' gtkhtml2:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' gtksourceview:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' inkscape:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' librsvg:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' mysql-query-browser:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data' planner:/opt/gnome/lib/libgnomeprintui-2-2.so: undefined reference to `gp_gc_set_data'
Jody, we need this fixed ASAP!
Did we not update libgnomeprintui with libgnomeprint ? They need to go in lock step for this patch.
Okay, sorry for the misunderstanding. libgnomeprintui is now also submitted.
Reopening as Blocker, because after YOU system contains conflicts. We need to release libgnomecups-devel, too. libgnomecups-devel requires libgnomecups = 0.2.1, but libgnomecups provides 0.2.2.
What's the point of including libgnomeprint-doc and libgnomeprintui-doc in the patch? Why shouldn't we just release libgnomecups and libgnomecups-devel? Why release libgnomeprint and libgnomeprintui again, the packages are unchanged, aren't they?
They are completely unchanged. I really didn't have a clue how all of this works. Please just push the same version of libgnomecups and libgnomecups-devel so that the upgrade works with you.