Bug 1192012 - release trigger pushed non-published images
Summary: release trigger pushed non-published images
Status: NEW
Alias: None
Product: openSUSE.org
Classification: openSUSE
Component: BuildService (show other bugs)
Version: unspecified
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Adrian Schröter
QA Contact: Adrian Schröter
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-10-25 20:29 UTC by Robert Schweikert
Modified: 2021-11-16 13:41 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Schweikert 2021-10-25 20:29:03 UTC 
When an image build project has

PublishFlags: noearlykiwipublish

set in the project config to ensure images only get published when all images in the project succeed build it is still possible to images from this project that have completed built but did not get published due to some other image build failure in the project to another project via a release, i.e. the 

trigger/release

api uses the latest built but not published images.

The build service should only release images in a project that are published.
Comment 2 Adrian Schröter 2021-10-26 05:44:44 UTC 
no, sorry, this is not going how it works, since it must be possible to re-create the publish area based on the build results. It would not be possible to create a reproducible state and we would need to backup way more content.

Btw noearlykiwipublish would not have the effect you described, it just waits until all finished (no matter if succeeded or failed). "nofailedpackages" would have that effect, maybe you are using that?

Maybe this would be an option to set "nofailedpackages" in source and target project to block any release when one build has failed?

I have to admit, that I am not sure how "nofailedpackages" is behave in release target projects, but we could get it working to take care about the build results.

Would this solve your issue?
Comment 3 Adrian Schröter 2021-10-26 05:45:49 UTC 
it would not block the release command, but it would block the publishing in the target to be exact.
Comment 4 Adrian Schröter 2021-10-26 11:59:31 UTC 
we could also added further optional checks for the release command, but we should discuss this directly maybe....
Comment 5 Robert Schweikert 2021-10-26 12:08:26 UTC 
nofailedpackages is also set in the project.

OK, will find a time slot.
Comment 6 Marcus Schaefer 2021-11-16 09:39:15 UTC 
why is this assigned to me ?
Comment 7 Robert Schweikert 2021-11-16 13:41:34 UTC 
Marcus, this should not be assigned to you. Based on the conversation with Adrian he was going to create a request in Jira and then close this bug.