Bug 119206 - asus-acpi kernel module goes beserk on L5D series notebook
Summary: asus-acpi kernel module goes beserk on L5D series notebook
Status: RESOLVED FIXED
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Kernel (show other bugs)
Version: unspecified
Hardware: x86-64 SUSE Other
: P0 - Crit Sit : Major
Target Milestone: ---
Assignee: Olaf Kirch
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-28 12:15 UTC by Simon Morgan
Modified: 2005-10-11 11:30 UTC (History)
0 users

See Also:
Found By: Beta-Customer
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
patch for asus_acpi kernel module (1.78 KB, patch)
2005-09-28 12:27 UTC, Simon Morgan
Details | Diff
patch for asus_acpi.c against HEAD (1.89 KB, patch)
2005-10-10 13:41 UTC, Timo Hoenig
Details | Diff
patch for asus_acpi.c against HEAD (1.89 KB, patch)
2005-10-10 13:53 UTC, Timo Hoenig
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Morgan 2005-09-28 12:15:23 UTC
LCD status message randomly appears on screen and system log fills with message:
"Asus ACPI: Error reading LCD status"

This happens with kernels 2.6.10 onwards and affects SuSE 9.3 and 10.0

I have attached a patch to the asus_acpi.c file to add explicit support for the
L5D series. I have also reported this to the kernel bugzilla system but nothing
has happened so I submit it here.

CUT HERE ======================================================

--- linux/drivers/acpi/asus_acpi.c	2005-03-20 15:34:04.000000000 +0000
+++ linux/drivers/acpi/asus_acpi.c	2005-06-02 12:22:41.000000000 +0100
@@ -124,6 +124,7 @@
 		L3D,      //L3400D
 		L3H,      //L3H, but also L2000E
 		L4R,      //L4500R
+		L5D,	  //L5000D/DF 
 		L5x,      //L5800C 
 		L8L,      //L8400L
 		M1A,      //M1300A
@@ -263,6 +264,19 @@
 		.display_get       = "\\_SB.PCI0.P0P1.VGA.GETD"
 	},
 
+        {
+                .name              = "L5D",
+                .mt_mled           = "MLED",
+/* WLED present, but not controlled by ACPI */
+/* TLED does not exist */
+/* .mt_lcd_switch does not exist - handled by hardware */
+/* .lcd_status  - unneccesary, see above */
+                .brightness_set    = "SPLV",
+                .brightness_get    = "GPLV",
+                .display_set       = "SDSP",
+                .display_get       = "\\INFB"
+        },
+
 	{
 		.name              = "L5x",
 		.mt_mled           = "MLED",
@@ -622,7 +636,7 @@
 {
 	int lcd = 0;
 
-	if (hotk->model != L3H) {
+	if (hotk->model != L3H && hotk->model != L5D) {
 	/* We don't have to check anything if we are here */
 		if (!read_acpi_int(NULL, hotk->methods->lcd_status, &lcd))
 			printk(KERN_WARNING "Asus ACPI: Error reading LCD status\n");
@@ -667,7 +681,7 @@
 	lcd = value ? 1 : 0;
 	if (lcd != get_lcd_state()) {
 		/* switch */
-		if (hotk->model != L3H) {
+		if (hotk->model != L3H && hotk->model != L5D) {
 			status =
 			    acpi_evaluate_object(NULL, hotk->methods->mt_lcd_switch,
 						 NULL, NULL);
@@ -1054,6 +1068,8 @@
 		hotk->model = A2x;
 	else if (strncmp(model->string.pointer, "J1", 2) == 0)
 		hotk->model = S2x;
+	else if (strncmp(model->string.pointer, "L5D", 3) == 0)
+                hotk->model = L5D;
 	else if (strncmp(model->string.pointer, "L5", 2) == 0)
 		hotk->model = L5x;
 
CUT HERE =======================
Comment 1 Simon Morgan 2005-09-28 12:27:58 UTC
Created attachment 51050 [details]
patch for asus_acpi kernel module

Adds explicit support for L5D series notebooks and fixes a bug where the syslog
fills with the message "Asus ACPI: Error reading LCD status"
Comment 2 Thomas Renninger 2005-10-07 12:56:07 UTC
what should we do with this one.
Is worth adding to 10.0?
Timo maybe you can propagate this change to mainline...
Comment 3 Timo Hoenig 2005-10-10 08:23:20 UTC
Yes, the patch looks good to me.

I was hoping that the L5D would match with the L5 but looks like I was wrong.
Comment 4 Timo Hoenig 2005-10-10 13:41:36 UTC
Created attachment 52080 [details]
patch for asus_acpi.c against HEAD
Comment 5 Timo Hoenig 2005-10-10 13:53:07 UTC
Comment on attachment 52080 [details]
patch for asus_acpi.c against HEAD

typo
Comment 6 Timo Hoenig 2005-10-10 13:53:55 UTC
Created attachment 52081 [details]
patch for asus_acpi.c against HEAD
Comment 7 Timo Hoenig 2005-10-10 13:55:16 UTC
Olaf, can you please apply the patch to our kernel tree?  It's compile tested.
Comment 8 Olaf Kirch 2005-10-11 11:30:54 UTC
I don't think HEAD is the right place - it's the development tree for SL10.1. 
I added this patch to the 10.0 branch; it will be in the next update  
kernel.