Bug 1194803 - skelcd-control-SMO: Broken i18n support
skelcd-control-SMO: Broken i18n support
Status: REOPENED
Classification: SUSE Linux Enterprise Server
Product: Public SUSE Linux Enterprise Micro 5.1
Classification: SUSE Linux Enterprise Server
Component: Installation
unspecified
Other Other
: P5 - None : Normal
: ---
Assigned To: Jiri Srain
Jiri Srain
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2022-01-18 00:54 UTC by Stanislav Brabec
Modified: 2022-01-19 13:23 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stanislav Brabec 2022-01-18 00:54:09 UTC
While preparing translation project for SLE15 SP4, y2makepot fails on skelcd-control-SMO with:

** ERROR: Missing textdomain in file /home/sbrabec/yast-checkout/skelcd-control-SMO/./control/control.SMO.glade

It makes impossible to update translations.

The bug is reproducible on yast-checkout, master branch.
Comment 1 Stanislav Brabec 2022-01-18 01:15:03 UTC
Other packages affected by the same problem:
bug 1194801: sap-installation-wizard
bug 1194803: skelcd-control-SMO
bug 1194804: y2status
Comment 2 David Diaz 2022-01-18 09:24:52 UTC
(In reply to Stanislav Brabec from comment #0)
> While preparing translation project for SLE15 SP4, y2makepot fails on
> skelcd-control-SMO with:
> 
> ** ERROR: Missing textdomain in file
> /home/sbrabec/yast-checkout/skelcd-control-SMO/./control/control.SMO.glade
> 

For this one, running `rake pot` locally gives me a grep error first

> grep: ./control/control.SMO.glade: No such file or directory
> ** ERROR: Missing textdomain in file /usr/src/app/./control/control.SMO.glade
rake aborted!

This grep error comes from [1] and [2].

[1] https://github.com/yast/yast-devtools/blob/cdf21f748873d1d6821fd3416921617f2274a71d/build-tools/scripts/gettextdomains#L56-L57
[2] https://github.com/yast/skelcd-control-SMO/blob/master/POTFILES
Comment 3 David Diaz 2022-01-18 10:41:25 UTC
This should be fixed with changes sent to skelcd-control-SMO repository.

See

 * SLE-Micro-5.0: https://github.com/yast/skelcd-control-SMO/pull/20
 * SLE-Micro-5.1: https://github.com/yast/skelcd-control-SMO/pull/21
 * SLE-Micro-5.2: 
   https://github.com/yast/skelcd-control-SMO/pull/22
   https://build.suse.de/request/show/262441

But please, note that this skelcd is not related to SLE-15-SP4 at all.

Thank you!
Comment 4 Stanislav Brabec 2022-01-18 23:33:53 UTC
However it is not a part of SLE15 SP4, its strings are part of the generated control.pot, which IS part of the SLE15 SP4, as it contains strings from skelcd-control-SLES.

As we have no tool to order translations for a part of the po file, we are always paying for a complete translation of control.pot.
Comment 5 Stanislav Brabec 2022-01-19 01:47:15 UTC
Could you push the changes to master as well? Even if the master branch is not in use for products, the bug breaks y2makepot for the whole yast-translations.

y2m read-only ALL
y2m pull
y2makepot

This still fails with:

** ERROR: Missing textdomain in file /home/sbrabec/yast-checkout/skelcd-control-SMO/./control/control.SMO.glade

https://github.com/yast/skelcd-control-SMO/pull/23
If you find a better way to collect translations, exclude skelcd-control-SMO, but include it in its respective products, please let me know.

Warning: Please note that all skelcd* packages share a single translation domain and a single translation file in the yast-translations package. It means, that the translation work flow will not work for branches of skelcd-control-SMO.
Comment 6 David Diaz 2022-01-19 13:23:16 UTC
(In reply to Stanislav Brabec from comment #5)
> Could you push the changes to master as well? Even if the master branch is
> not in use for products, the bug breaks y2makepot for the whole
> yast-translations.
> 
> y2m read-only ALL
> y2m pull
> y2makepot
> 
> This still fails with:
> 
> ** ERROR: Missing textdomain in file
> /home/sbrabec/yast-checkout/skelcd-control-SMO/./control/control.SMO.glade
> 
> https://github.com/yast/skelcd-control-SMO/pull/23

I have approved and merged it. Let us know if it fixes the problem.


> If you find a better way to collect translations, exclude
> skelcd-control-SMO, but include it in its respective products, please let me
> know.

I'm not quite familiar with the translation process at this time. And this looks like a special corner case. Anyway, I'll ping you if I learn something to that regard.

> 
> Warning: Please note that all skelcd* packages share a single translation
> domain and a single translation file in the yast-translations package. It
> means, that the translation work flow will not work for branches of
> skelcd-control-SMO.