Bug 1201127 - python-brotlicffi / setuptools build_ext reproducible builds
Summary: python-brotlicffi / setuptools build_ext reproducible builds
Status: VERIFIED FIXED
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Other (show other bugs)
Version: Current
Hardware: Other All
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Daniel Garcia
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-04 04:06 UTC by Bernhard Wiedemann
Modified: 2023-05-04 09:01 UTC (History)
1 user (show)

See Also:
Found By: Development
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernhard Wiedemann 2022-07-04 04:06:36 UTC
I found
https://github.com/python-hyper/brotlicffi/blob/main/setup.py#L66
needed a "sorted(sources)" to become fully reproducible,
but IMHO that should not have to be added into setup.py
but one layer up, e.g. in build_ext
similar to
https://github.com/pypa/setuptools/commit/5a0404fa3875a069f7a6436f508116e852909cf2
https://github.com/pypa/setuptools/pull/1068/files
Comment 1 Daniel Garcia 2022-11-14 12:53:12 UTC
I've created an issue in setuptools github [1], and also created the corresponding PR to solve the issue [2], that should make this kind of build reproducible.

Let's see how the review process go and if it's accepted we can bring that change to our package.

[1] https://github.com/pypa/setuptools/issues/3678
[2] https://github.com/pypa/setuptools/pull/3679
Comment 2 Daniel Garcia 2022-11-23 16:24:38 UTC
Patch has been merged and there's a new setuptools release (65.6.1) with this change.

I've also created a request with this new update for Factory, so we can close this as fixed.

https://build.opensuse.org/request/show/1037646
Comment 3 Bernhard Wiedemann 2022-11-24 07:34:10 UTC
I verified the fix. Works fine.
Comment 4 OBSbugzilla Bot 2022-11-24 11:45:03 UTC
This is an autogenerated message for OBS integration:
This bug (1201127) was mentioned in
https://build.opensuse.org/request/show/1037861 Factory / python-setuptools