Bug 1211810 - Enable THREADING with PTHREAD by changing include file (not CMake commandline)
Summary: Enable THREADING with PTHREAD by changing include file (not CMake commandline)
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Other (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Otto Hollmann
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-29 18:35 UTC by Arjen de Korte
Modified: 2023-08-30 09:50 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arjen de Korte 2023-05-29 18:35:50 UTC 
Setting the following parameters in the CMake commandline won't update the include/mbedtls/mbedtls_config.h file:

 -DMBEDTLS_THREADING_C=ON \
 -DMBEDTLS_THREADING_PTHREAD=ON \

Application linking this library use the mbedtls_config.h file to see what options the library was build with. Therefor it is better to uncomment these defines in the include file, so that both library and applications linking to it have the same starting point.

See https://build.opensuse.org/request/show/1089636
Comment 1 Simon Lees 2023-08-04 02:28:20 UTC 
Reassigning to the mbedtls maintainers as this seems specific to that package rather then cmake in general
Comment 2 Arjen de Korte 2023-08-04 05:05:48 UTC 
This is already fixed in MbedTLS, so this can be closed (see https://build.opensuse.org/request/show/1089650)
Comment 3 Pedro Monreal Gonzalez 2023-08-30 09:50:36 UTC 
(In reply to Simon Lees from comment #1)
> Reassigning to the mbedtls maintainers as this seems specific to that
> package rather then cmake in general

Note that, Otto is not the maintainer of mbedtls. See:

> osc maintainer -e mbedtls
> Defined in package: security:tls/mbedtls 
>  bugowner of mbedtls : 
>    -
>  maintainer of mbedtls : 
>    mpluskal@suse.com, fisiu@opensuse.org