Bug 1211986 - Replace Goldendict-ng by official Goldendict
Summary: Replace Goldendict-ng by official Goldendict
Status: RESOLVED WONTFIX
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: X11 Applications (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: E-mail List
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-06-04 19:16 UTC by Aleksey Kontsevich
Modified: 2023-06-05 18:20 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksey Kontsevich 2023-06-04 19:16:10 UTC
goldendict-ng is terrible and has a lot of bugs! 
https://github.com/goldendict/goldendict/issues/1650 - thought it is new 1.5 version problems, but it is about goldendict-ng actually!

Please replace by the official version: 
https://github.com/goldendict/goldendict/releases/tag/1.5.0
Comment 1 slb 2023-06-05 03:25:46 UTC
The original Goldendict version was removed in 2021.

openSUSE has been using the fork (goldendict-ng)'s branch since early 2022. You have been using this fork for over a year.

Even today, the original GD is not buildable on openSUSE tumbleweed because QtWebkit was removed. There is no way to use it.

---

In the GitHub issue:

Problem 1 is fixed, which is because of Qt6's update. If the original GD updates to Qt6, the problem will occur too.

The ScanPopup Ctrl+Alt problem is because Scanpopup-related things were redesigned (to make it work on all platforms); just re-enable it in settings.

The missing KDE theme is because KDE doesn't support Qt6 yet. All Qt6 apps cannot KDE theme yet.
Comment 2 Aleksey Kontsevich 2023-06-05 12:31:29 UTC
(In reply to slb from comment #1)
> The original Goldendict version was removed in 2021.

Missed this.

> openSUSE has been using the fork (goldendict-ng)'s branch since early 2022.
> You have been using this fork for over a year.

No, I have not used it: I used 
- https://build.opensuse.org/package/show/office%3Agoldendict/goldendict-qwebengine-port 
> and then version from:
- https://build.opensuse.org/package/show/Education/goldendict
And only recent days zypper dup forced me to overwrite them by goldendict-ng for some reason - I do not know why?!

> Even today, the original GD is not buildable on openSUSE tumbleweed because
> QtWebkit was removed. There is no way to use it.

Where it was removed?! Why Education or office%3Agoldendict semi-official repos can build it and you can't?!

> In the GitHub issue:
> 
> Problem 1 is fixed, which is because of Qt6's update. If the original GD
> updates to Qt6, the problem will occur too.

Not, fixed!!! And there are multiple problems mentioned - not only GD.

> 
> The ScanPopup Ctrl+Alt problem is because Scanpopup-related things were
> redesigned (to make it work on all platforms); just re-enable it in settings.

Reenabled - does not work!

> The missing KDE theme is because KDE doesn't support Qt6 yet. All Qt6 apps
> cannot KDE theme yet.

Bad!

Tray icon click also does not work!
Comment 3 Christophe Marin 2023-06-05 13:07:12 UTC
(In reply to Aleksey Kontsevich from comment #2)
> (In reply to slb from comment #1)
> > The original Goldendict version was removed in 2021.
> 
> Missed this.
> 
> > openSUSE has been using the fork (goldendict-ng)'s branch since early 2022.
> > You have been using this fork for over a year.
> 
> No, I have not used it: I used 
> -
> https://build.opensuse.org/package/show/office%3Agoldendict/goldendict-
> qwebengine-port 
> > and then version from:
> - https://build.opensuse.org/package/show/Education/goldendict
> And only recent days zypper dup forced me to overwrite them by goldendict-ng
> for some reason - I do not know why?!

Your problem then. The package in the Education project is broken since goldendict removal in openSUSE:Factory.

The package from the office:goldendict repo wasn't updated since months.

> 
> > Even today, the original GD is not buildable on openSUSE tumbleweed because
> > QtWebkit was removed. There is no way to use it.
> 
> Where it was removed?! Why Education or office%3Agoldendict semi-official
> repos can build it and you can't?!

QtWebkit was dropped from openSUSE:Factory long ago. Any package still using it is insecure and should not be installed.

Since there's no chance goldendict (not goldendict-ng) gets added back to openSUSE:Factory, closing this bug was the right decision. No need to reopen it.
Comment 4 Aleksey Kontsevich 2023-06-05 13:13:38 UTC
(In reply to Christophe Marin from comment #3)
> (In reply to Aleksey Kontsevich from comment #2)

> > No, I have not used it: I used 
> > -
> > https://build.opensuse.org/package/show/office%3Agoldendict/goldendict-
> > qwebengine-port 
> > > and then version from:
> > - https://build.opensuse.org/package/show/Education/goldendict
> > And only recent days zypper dup forced me to overwrite them by goldendict-ng
> > for some reason - I do not know why?!
> 
> Your problem then. 

Not clear: WHAT is my problem?! Why zypper dup replaces goldendict by goldendict-ng as they co-exist for a year?!

>The package in the Education project is broken since goldendict removal in openSUSE:Factory.

In what way it is broken?! It works just fine.

>The package from the office:goldendict repo wasn't updated since months.

True: has broken dependencies now.

>QtWebkit was dropped from openSUSE:Factory long ago. 

Why?!

>Any package still using it is insecure and should not be installed.

How goldendict could be insecure?!
Comment 5 slb 2023-06-05 14:04:46 UTC
> No, I have not used it: I used 
> - https://build.opensuse.org/package/show/office%3Agoldendict/goldendict-qwebengine-port 

Read the `_service` file and see where the code comes from.

https://build.opensuse.org/package/view_file/office:goldendict/goldendict-qwebengine-port/_service

> git://github.com/xiaoyifang/goldendict.git

The fork (-ng) is the primary reason you can use the software in the past year!

---

Of course, it is partially my bad to upgrade it to Qt6, which triggers a bug which is also present in the original GD, and I have fixed it:

https://github.com/xiaoyifang/goldendict-ng/pull/812

I have prepared a new version which includes the fix, but it requires time to update:

https://build.opensuse.org/package/show/home:slbtongying/goldendict-ng
Comment 6 Aleksey Kontsevich 2023-06-05 14:09:24 UTC
(In reply to slb from comment #5)
> The fork (-ng) is the primary reason you can use the software in the past
> year!

Ok, thanks! Fun UI is so different then.

> Of course, it is partially my bad to upgrade it to Qt6, which triggers a bug
> which is also present in the original GD, and I have fixed it:
> 
> https://github.com/xiaoyifang/goldendict-ng/pull/812
> 
> I have prepared a new version which includes the fix, but it requires time
> to update:
> 
> https://build.opensuse.org/package/show/home:slbtongying/goldendict-ng

Thank You! Will wait.
Comment 7 Aleksey Kontsevich 2023-06-05 14:24:08 UTC
(In reply to Christophe Marin from comment #3)

You can switch to the original version now as Qt WebKit was replaced by Qt 5 WebEngine - see this comment: https://github.com/goldendict/goldendict/issues/1650#issuecomment-1576852364
Comment 8 slb 2023-06-05 15:32:57 UTC
> Ok, thanks! Fun UI is so different then.

HiDPI screen is a thing. The icons must be changed. The old ones are blurry on screen with higher resolution.

We can revert to Qt5 to use KDE's theme.
Comment 9 Christophe Marin 2023-06-05 15:58:41 UTC
(In reply to Aleksey Kontsevich from comment #7)
> (In reply to Christophe Marin from comment #3)
> 
> You can switch to the original version now as Qt WebKit was replaced by Qt 5
> WebEngine - see this comment:
> https://github.com/goldendict/goldendict/issues/1650#issuecomment-1576852364

This merge request was submitted ~10 months ago and not accepted. Why would anyone waste time with a semi-abandoned app when there's goldendict-ng?
Comment 10 slb 2023-06-05 17:41:41 UTC
The irony:

The PR mentioned and made by this "vedgy" is a copy & paste of the fork's PR from last year after thoroughly looking at the code for mouths.

https://github.com/goldendict/goldendict/pull/1447

Then after a year, he cannot make it work.

---

The "original GD" you have been using is the work of the fork's developer.

https://build.opensuse.org/package/view_file/Education/goldendict/_service

---

I am not going to talk to you anymore.

The regressions will be fixed in a few days, possibly by reverting back to qt5.
Comment 11 Aleksey Kontsevich 2023-06-05 18:20:32 UTC
(In reply to slb from comment #10)

> The regressions will be fixed in a few days, possibly by reverting back to
> qt5.

Thanks for the good feedback and quick fixes, I was not aware of all the situation and probably nobody was. Will try goldendict-ng after all the fixes and good if with qt5. For now on older version.