Bug 1214360 - suse-module-tools: kmp-install still needed? (it's perl)
Summary: suse-module-tools: kmp-install still needed? (it's perl)
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Martin Wilck
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1170066
  Show dependency treegraph
 
Reported: 2023-08-17 11:35 UTC by Ludwig Nussel
Modified: 2024-01-03 10:32 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ludwig Nussel 2023-08-17 11:35:51 UTC
kmp-install in suse-module-tools is one of very few scripts left in a minimal system that require Perl. Not sure it's worth rewriting in some other language. Is the tool actually still needed all? I didn't even know about it :-)
Comment 1 Martin Wilck 2023-08-18 16:49:52 UTC
It's probably not needed any more. Perhaps we should just ditch it.

This would be part of a general s-m-t overhaul. Similar for driver-check.sh
From time to time I realize that these hardly-used scripts are broken, and try to fix them but I'd rather get rid of them for good.

Can we just go ahead with this, or do we need a Jira / an upstream discussion?
Comment 2 Ludwig Nussel 2023-09-04 08:42:04 UTC
I don't know, aren't you upstream of this tool? :-)
Comment 3 Martin Wilck 2023-09-04 16:19:08 UTC
I don't think I am upstream, at least I've never  thought of myself this way ... but yes, I maintain the package.

Send a PR.
Comment 4 Martin Wilck 2023-09-18 11:03:15 UTC
@Scott,

-------------------------------------------------------------------
Fri Mar 28 14:25:25 UTC 2014 - mmarek@suse.cz

- Add kmp-install tool for easier installation of SolidDriver KMPs
  (fate#314581).

Usage: kmp-install [options] <package> ...
Installs given packages and removes any KMPs that contain conficting module
names. Run 'zypper help install' for the list of valid options. Additionally,
the options --non-interactive and --non-interactive-include-reboot-patches
can be used

@Scott, I can't access fate#314581, and as this was before I started at SUSE, I don't understand exactly what this tool was supposed to achieve.

AFAICS it compares the set of installed and to-be-installed KMPs, checks for file conflicts, and marks any previously installed patcakges that contain conflicting files for removal, building and builds a zypper command line that uses zyppers's "negative install" feature to both install and delete packages in a single zypper call.

Apparently this is a workaround for some deficiency of zypper itself resolving 
conflicts for KMPs with different versions / names?

I have never used this tool, and I'm not a aware of any concrete use cases.

Is it still necessary?
Comment 5 Martin Wilck 2023-09-18 11:03:57 UTC
Also adding Michal, perhaps he is aware of use cases.
Comment 6 Michal Suchanek 2023-09-18 11:40:30 UTC
No idea if it's used. I have very little idea about SolidDriver.

Probably should open a JIRA ticket for removal in SLE, in Factory/ALP it's probably OK to drop and only add it back if somebody complains.
Comment 7 Martin Wilck 2023-09-18 14:02:48 UTC
Ludwig's request for removal was because it's written in perl and apparently we're trying to get rid of perl in the distro core. That doesn't matter much for SLE, so for SLE we might as well just keep the tool.
Comment 8 Scott Bahling 2023-09-26 15:39:15 UTC
I actually don't recall this tool at all and we don't leverage it directly in the SolidDriver Program. Unfortunately I don't have access to the original Fate request to understand the background for needing the tool.
Comment 10 Martin Wilck 2023-12-15 10:49:43 UTC
comment 9 applied in s-m-z master branch.
Comment 11 OBSbugzilla Bot 2023-12-18 21:35:02 UTC
This is an autogenerated message for OBS integration:
This bug (1214360) was mentioned in
https://build.opensuse.org/request/show/1133907 Factory / suse-module-tools
Comment 12 Martin Wilck 2024-01-03 10:32:04 UTC
In progress on OBS, closing bug