Bug 1214769 - branding-openSUSE: Request to remove grub2 BuildRequires
Summary: branding-openSUSE: Request to remove grub2 BuildRequires
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Current
Hardware: All openSUSE Tumbleweed
: P5 - None : Major (vote)
Target Milestone: ---
Assignee: Fabian Vogt
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-08-30 06:31 UTC by Michael Chang
Modified: 2023-08-30 07:39 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Chang 2023-08-30 06:31:02 UTC
It seems that the grub2 package is not used in the building process of branding-openSUSE package. All the grub theme related materials were pre-generated and maintained as binaries in the source, especially the fonts, that no indication of grub2-mkfont is used in the build scripts. Therefore it is no reason to keep the grub2 as BuildRequires and should be removable to have a clean dependency.

The question arises when new grub version enforces verifying signed font for UEFI Secure Boot so that grub2 package added embedded fonts to the signed grub.efi image. At first we tries to use grub2-mkfont to generate the font files from the build system, but for some reason (perhaps due to fontconfig or original linux font files has changed) we cannot reproduce identical result to have the same look of fonts displayed in boot menu provided by branding package. To avoid breaking openSUSE testing with unmatched needles and also the knowledge to recreate the font files is apparent lost, the branding-openSUSE was added to grub2 package as BuildRequires so the it's font files can be used directly in signed grub image.

However, after submitting to factory, the staging QA detected a loop dependency so that we worked on this bug report. I have also tested removing the grub2 in BuildRequires and it didn't seem to have any impact to the resultant build.  For that I'd like to ask is there any concern for submitting the change of removing grub2 BuildRequires to branding-openSUSE package ? Thanks in advanced.
Comment 1 Michael Chang 2023-08-30 07:13:04 UTC
As long as the change is trivial, I just go ahead and create the submit request:

https://build.opensuse.org/request/show/1108038

Please review. Thanks.
Comment 2 Fabian Vogt 2023-08-30 07:31:48 UTC
I came to the same conclusion. If it breaks something we'll see.
Comment 3 Michael Chang 2023-08-30 07:39:02 UTC
(In reply to Fabian Vogt from comment #2)
> I came to the same conclusion. If it breaks something we'll see.

Thank you. Looking forward to everything going well. :)