Bug 1215681 - vlc: needs update for mpeg123 version 1.32.1
Summary: vlc: needs update for mpeg123 version 1.32.1
Status: RESOLVED INVALID
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Other (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Dominique Leuenberger
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-25 14:11 UTC by Ana Guerrero
Modified: 2023-09-28 08:50 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
build log (1.29 MB, text/plain)
2023-09-25 14:11 UTC, Ana Guerrero
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ana Guerrero 2023-09-25 14:11:48 UTC
Created attachment 869725 [details]
build log

vlc needs to be updated to build against mpeg123 version 1.32.1 (SR https://build.opensuse.org/request/show/1113262 )

Attached is the full build log with the failure.
Comment 1 Dominique Leuenberger 2023-09-27 13:02:42 UTC
The build error is something along the lines of:

[  154s] /home/abuild/rpmbuild/BUILD/vlc-3.0.18/modules/codec/mpg123.c:282: undefined reference to `mpg123_decode_frame_64'


Looking at the code, this does look like an mpg123 own-introduced error.

e.g vlc does, in line 282 (as referenced in the error)

        i_err = mpg123_decode_frame( p_sys->p_handle, NULL, NULL, &i_bytes );
(note, no _64 suffix)

mpg123.h defines mpeg123_decode_frame like this:

#define mpg123_decode_frame MPG123_LARGENAME(mpg123_decode_frame)


#define MPG123_LARGENAME(func) MPG123_MACROCAT(func, MPG123_LARGESUFFIX)
which leads to:
#define MPG123_LARGESUFFIX MPG123_MACROCAT(_, _FILE_OFFSET_BITS)

here, the _64 suffix is added..
Comment 2 Dominique Leuenberger 2023-09-28 08:50:25 UTC
mpg123 update just declared:

- Update to version 1.32.2
+  * libmpg123: Re-introduce _64 symbols on native 64 bit offset
+    platforms. This was a regression since 1.31 series. Sorry,
+    too much cleanup, not enough testing.

=> confirming that my analysis above was correct; VLC builds with this version of mpg123