Bug 1215701 (CVE-2023-40581) - VUL-0: CVE-2023-40581: yt-dlp: template expansion in `--exec` flag
Summary: VUL-0: CVE-2023-40581: yt-dlp: template expansion in `--exec` flag
Status: RESOLVED INVALID
Alias: CVE-2023-40581
Product: openSUSE Distribution
Classification: openSUSE
Component: Security (show other bugs)
Version: Leap 15.6
Hardware: Other Other
: P3 - Medium : Major (vote)
Target Milestone: ---
Assignee: Jan Engelhardt
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/379815/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-09-26 06:26 UTC by SMASH SMASH
Modified: 2024-06-12 14:51 UTC (History)
2 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2023-09-26 06:26:19 UTC
yt-dlp is a youtube-dl fork with additional features and fixes. yt-dlp allows
the user to provide shell command lines to be executed at various stages in its
download steps through the `--exec` flag. This flag allows output template
expansion in its argument, so that metadata values may be used in the shell
commands. The metadata fields can be combined with the `%q` conversion, which is
intended to quote/escape these values so they can be safely passed to the shell.
However, the escaping used for `cmd` (the shell used by Python's `subprocess` on
Windows) does not properly escape special characters, which can allow for remote
code execution if `--exec` is used directly with maliciously crafted remote
data. This vulnerability only impacts `yt-dlp` on Windows, and the vulnerability
is present regardless of whether `yt-dlp` is run from `cmd` or from
`PowerShell`. Support for output template expansion in `--exec`, along with this
vulnerable behavior, was added to `yt-dlp` in version 2021.04.11. yt-dlp version
2023.09.24 fixes this issue by properly escaping each special character. `\n`
will be replaced by `\r` as no way of escaping it has been found. It is
recommended to upgrade yt-dlp to version 2023.09.24 as soon as possible. Also,
always be careful when using --exec, because while this specific vulnerability
has been patched, using unvalidated input in shell commands is inherently
dangerous. For Windows users who are not able to upgrade: 1. Avoid using any
output template expansion in --exec other than {} (filepath). 2. If expansion in
--exec is needed, verify the fields you are using do not contain ", | or &. 3.
Instead of using --exec, write the info json and load the fields from it
instead.


References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-40581
Comment 2 Robert Frohl 2023-09-26 06:31:20 UTC
Already fixed in Factory, still pending for openSUSE:Backports:SLE-15-SP*
Comment 5 Camila Camargo de Matos 2024-06-12 14:51:22 UTC
The bug was closed as this looks to be an issue that only affects Windows systems.