Bug 1216736 - Re-enable CONFIG_NFS_V4_2_READ_PLUS in master
Summary: Re-enable CONFIG_NFS_V4_2_READ_PLUS in master
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Kernel:Filesystems (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Kernel Filesystems
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-10-31 10:20 UTC by Petr Tesařík
Modified: 2023-11-01 09:01 UTC (History)
3 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
patch against kernel-source commit 2d6110a1547f (3.31 KB, patch)
2023-10-31 10:20 UTC, Petr Tesařík 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Tesařík 2023-10-31 10:20:30 UTC 
Created attachment 870533 [details]
patch against kernel-source commit 2d6110a1547f

CONFIG_NFS_V4_2_READ_PLUS config option was unselected by commit ff9060bd2d19
("Update to 5.10 final"). This is understandable given the observed failures
with xfstests mentioned in mainline commit 21e31401fc45 ("NFS: Disable
READ_PLUS by default").

However, it seems that all issues have been worked out, see mainline commit
9cf2744d2491 ("NFS: Enable the READ_PLUS operation by default"). I suggest we
re-enable CONFIG_NFS_V4_2_READ_PLUS in master now. It allows to transfer
sparse files more efficiently.
Comment 1 David Disseldorp 2023-10-31 12:19:17 UTC 
(In reply to Petr Tesařík from comment #0)
...
> However, it seems that all issues have been worked out, see mainline commit
> 9cf2744d2491 ("NFS: Enable the READ_PLUS operation by default"). I suggest we
> re-enable CONFIG_NFS_V4_2_READ_PLUS in master now. It allows to transfer
> sparse files more efficiently.

Seems reasonable to me to follow mainline 6.6... Thanks for the patch Petr! I'll queue this up in my for-next after going through the before / after xfstests results. I'm assuming Author: Petr Tesarik <petr@tesarici.$country_code_tld> - let me know if you'd prefer a different email address.
Comment 2 Petr Tesařík 2023-10-31 13:43:02 UTC 
(In reply to David Disseldorp from comment #1)
> (In reply to Petr Tesařík from comment #0)
> ...
> > However, it seems that all issues have been worked out, see mainline commit
> > 9cf2744d2491 ("NFS: Enable the READ_PLUS operation by default"). I suggest we
> > re-enable CONFIG_NFS_V4_2_READ_PLUS in master now. It allows to transfer
> > sparse files more efficiently.
> 
> Seems reasonable to me to follow mainline 6.6... Thanks for the patch Petr!
> I'll queue this up in my for-next after going through the before / after
> xfstests results. I'm assuming Author: Petr Tesarik
> <petr@tesarici.$country_code_tld> - let me know if you'd prefer a different
> email address.

Yes, people can blame me at <petr@tesarici.cz>.
Comment 3 Neil Brown 2023-10-31 21:14:36 UTC 
Looks sensible to me - thanks.
Comment 4 Michal Kubeček 2023-11-01 08:05:39 UTC 
CONFIG_NFS_V4_2_READ_PLUS is has been enabled in both master and stable.
Thanks to everyone, closing.