Bug 1217076 - AUDIT-TRACKER: kde: tracker bug for various new revisions of (renamed) D-Bus services and PAM modules
Summary: AUDIT-TRACKER: kde: tracker bug for various new revisions of (renamed) D-Bus ...
Status: RESOLVED FIXED
Alias: None
Product: SUSE Security Incidents
Classification: Novell Products
Component: Audits (show other bugs)
Version: unspecified
Hardware: Other Other
: P5 - None : Normal
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL:
Whiteboard:
Keywords:
Depends on: 1217178 1217179 1217182 1217183 1217184 1217185 1217186 1217187 1217188 1217190 1217191 1220190 1220215
Blocks:
  Show dependency treegraph
 
Reported: 2023-11-13 10:05 UTC by Christophe Marin
Modified: 2024-07-05 12:41 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christophe Marin 2023-11-13 10:05:40 UTC
Hello,

The next KDE major release got its first alpha release, some new packages and some added for coinstallability need security reviews.

Upstream's release schedule is available there: https://community.kde.org/Schedules/February_2024_MegaRelease

The following packages are currently available in KDE:Unstable:Frameworks repository

* kf6-kauth will coexist with kauth (reviewed in bug 1176742) and returns:
kf6-kauth.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.kf6auth.conf

* kinfocenter6 will coexist (but won't be coinstallable) with kinfocenter (reviewed in bug 1199735) and returns:
kinfocenter6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.kinfocenter.dmidecode.service
kinfocenter6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.kinfocenter.dmidecode.conf

* libksysguard6 will coexist (but won't be coinstallable) with libksysguard (reviewed in bug 1151190) and returns:
libksysguard6-plugins.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.ksysguard.processlisthelper.service
libksysguard6-plugins.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.ksysguard.processlisthelper.conf

* pam_kwallet6 will coexist (but won't be coinstallable) with pam_kwallet (reviewed in bug 1208684) and returns:
pam_kwallet6.x86_64: E: pam-file-unauthorized (Badness: 10) /usr/lib64/security/pam_kwallet5.so

* plasma6-desktop will coexist (but won't be coinstallable) with plasma5-desktop (I didn't find the related plasma5 report) and returns:
plasma6-desktop.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.kcontrol.kcmclock.conf
plasma6-desktop.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.kcontrol.kcmclock.service

* plasma6-disks will coexist (but won't be coinstallable) with plasma5-disks (reviewed in bug 1176742) and returns:
plasma6-disks.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.kded.smart.conf
plasma6-disks.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.kded.smart.service

* plasma6-workspace will coexist (but won't be coinstallable) with plasma5-workspace (the related report wasn't found) and returns:
plasma6-workspace.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.fontinst.service
plasma6-workspace.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.fontinst.conf

* powerdevil6 will coexist (but won't be coinstallable) with powerdevil5 (reviewed in bug 1176474) and returns:
powerdevil6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.powerdevil.backlighthelper.conf
powerdevil6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.powerdevil.chargethresholdhelper.conf
powerdevil6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.powerdevil.backlighthelper.service
powerdevil6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.powerdevil.discretegpuhelper.conf
powerdevil6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.powerdevil.chargethresholdhelper.service
powerdevil6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.powerdevil.discretegpuhelper.service

sddm-kcm6 will coexist (but won't be coinstallable) with kcm_sddm  (reviewed in bug 1033292) and returns:
sddm-kcm6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.kcontrol.kcmsddm.conf
sddm-kcm6.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.kcontrol.kcmsddm.service

* kscreenlocker6 will coexist (but won't be coinstallable) with kscreenlocker. Doesn't warn, but new pam files are needed for unlocking screen with fingerprint devices or smartcard:
https://build.opensuse.org/package/view_file/KDE:Unstable:Frameworks/kscreenlocker6/kde-smartcard?expand=1
https://build.opensuse.org/package/view_file/KDE:Unstable:Frameworks/kscreenlocker6/kde-fingerprint?expand=1
https://build.opensuse.org/package/view_file/KDE:Unstable:Frameworks/kscreenlocker6/kde?expand=1 (identical to current one)

---

The following packages are currently available in KDE:Unstable:Applications repository. Unless mentioned, they will replace the existing packages in february

* kwalletmanager (previous review in bug 849739) returns:
kwalletmanager.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system-services/org.kde.kcontrol.kcmkwallet5.service
kwalletmanager.x86_64: E: dbus-file-unauthorized (Badness: 10) /usr/share/dbus-1/system.d/org.kde.kcontrol.kcmkwallet5.conf

kde-inotify-survey (previous review in bug 1208689) returns:
E: dbus-file-digest-mismatch (Badness: 10) /usr/share/dbus-1/system-services/org.kde.kded.inotify.service expected sha256:89a2ce5a4c6ebd7cb471f820a28fbd2dd418e377cb2ed0eaea1af59840c1dabd, has:e56b75bc5cbaa9e4dfb5829dcb5c0d5d871c0533076b83ea2c0f363c00318ad4
E: dbus-file-digest-mismatch (Badness: 10) /usr/share/dbus-1/system.d/org.kde.kded.inotify.conf expected sha256:4eb68f2c3bc75842df0f3d67874588fc672ec540769db09c3a71cbb292a989f7, has:1bf419225b109ad681d7bce85dcb82694b7bb56e336cf9c0e0f86318d18aca8f
Comment 1 Matthias Gerstner 2023-11-15 09:29:19 UTC
Wow this is a lot of changes. A single bug won't do. We can use this bug
merely as a tracker bug.

When will these packages actually hit Factory? Public release is scheduled for
the end of February, so for Factory this will likely be relevant around March.

We should be reviewing somewhat earlier than that for the case that anything
problematic is found that upstream needs to be working on.

But otherwise it looks not urgent. We can have a look as time permits until
the end of January or so.
Comment 2 Christophe Marin 2023-11-15 10:06:17 UTC
(In reply to Matthias Gerstner from comment #1)
> 
> When will these packages actually hit Factory? Public release is scheduled
> for
> the end of February, so for Factory this will likely be relevant around
> March.

The packages won't reach factory users before the release. Ideally, we should try test submissions around RC1 to check which changes are needed for staging projects.
Comment 3 Matthias Gerstner 2023-11-15 13:22:17 UTC
Do you have any insight about the volatility of the upstream codebase for
KDE6?

It wouldn't make much sense for us to review these alpha packages now if the
codebase will change a lot until the actual release happens.
Comment 4 Matthias Gerstner 2023-12-06 16:14:37 UTC
All sub-bugs have been taken care of - except for bug 1217179 (kinfocenter),
where Paolo will soon provide us more info.

There are only two hard blockers currently from my point of view:

- bug 1217186 plasma6-workspace fontinst service: this is pretty old code that
  was never reviewed properly by us in the past. And the code is way too open
  such that the actions can be misused for completely different things than
  what it says on the label.

- bug 1217188 sddm-kcm6: this service is just barely secure by requiring
  `auth_admin` for everything and even then it's shaky given that is writes to
  the `sddm` user's home directory as root.

For these two I would really like to see some upstream efforts for KDE6.

For all the other bugs there are a couple of comments for improvement here and
there but nothing that stands in the way of a whitelisting.
Comment 5 Matthias Gerstner 2024-02-06 14:06:45 UTC
(In reply to matthias.gerstner@suse.com from comment #4)
> For these two I would really like to see some upstream efforts for KDE6.
> 
> For all the other bugs there are a couple of comments for improvement here and
> there but nothing that stands in the way of a whitelisting.

So are there any news regarding the release schedule of KDE upstream?

I see no movement in the couple of issues that have been created upstream. It
feels like this chance to perform breaking changes in the context of a major
release is being dropped.
Comment 6 Fabian Vogt 2024-02-06 20:59:58 UTC
(In reply to Matthias Gerstner from comment #5)
> (In reply to matthias.gerstner@suse.com from comment #4)
> > For these two I would really like to see some upstream efforts for KDE6.
> > 
> > For all the other bugs there are a couple of comments for improvement here and
> > there but nothing that stands in the way of a whitelisting.
> 
> So are there any news regarding the release schedule of KDE upstream?

RC2 was released recently, the SRs to TW are being prepared.

> I see no movement in the couple of issues that have been created upstream.

Indeed.

The sddm handler needs rework anyway to handle theme installation outside of /usr anyway. IMO this functionality isn't that important yet as there won't be many Qt 6 compatible themes, so for now we can skip it.

For kfontinst I'll try to have a look myself, until that's done it can probably be skipped as well.

> It
> feels like this chance to perform breaking changes in the context of a major
> release is being dropped.

Not really, big changes to those interfaces can be done at any point in time and are actually easier to do once the dust has settled a bit... It's all just implementation details, there aren't any external interfaces to outside of Plasma or probably not even user visible effects.
Comment 7 Matthias Gerstner 2024-02-07 10:12:08 UTC
(In reply to fabian@ritter-vogt.de from comment #6)
> > It
> > feels like this chance to perform breaking changes in the context of a major
> > release is being dropped.
> 
> Not really, big changes to those interfaces can be done at any point in time and are actually easier to do once the dust has settled a bit... It's all just implementation details, there aren't any external interfaces to outside of Plasma or probably not even user visible effects.

I don't see it that way at least not for the change I suggested to the Kauth
interface. If there is a breaking change in there then all consumers of Kauth
need to be adapted.
Comment 8 Christophe Marin 2024-02-11 11:13:55 UTC
The next frameworks and plasma packages were submitted yesterday. the RC2 packages live in the KDE:Frameworks repository.
Comment 9 Matthias Gerstner 2024-02-14 12:27:35 UTC
I will soon submit whitelistings for most of the changed packages. A couple of
problematic items remain:

- kde.fontinst.service bug 1217186: much too broad D-Bus interface, no
  activity upstream. I will whitelist this for legacy reasons only.
- sddm-kcm6 bug 1217188: likely local attack vectors from sddm to root or
  interactive user to root. This is only kept halfway safe as it requires
  `auth_admin`. No movement visible from upstream. Asked how to continue here.
- kwalletmanager bug 1217190: this contains a useless kauth helper that is
  used for fake security purposes and I advice to drop this in any form
  possible.
Comment 10 Christophe Marin 2024-02-21 19:09:10 UTC
mmm... seems I forgot drkonqi6

[   93s] drkonqi6.x86_64: E: dbus-file-unauthorized (Badness: 10000) /usr/share/dbus-1/system.d/org.kde.drkonqi.conf (sha256 file digest default filter:233b3b98de2fc6b780c1eb9c3ab9b9f99b1949dfab951cababd7c5a717b8ee16 shell filter:233b3b98de2fc6b780c1eb9c3ab9b9f99b1949dfab951cababd7c5a717b8ee16 xml filter:3326c5271c6321c5b3a703d187443eef260d54aa7347bc8f05d9090a153a04bd)

[   93s] drkonqi6.x86_64: E: dbus-file-unauthorized (Badness: 10000) /usr/share/dbus-1/system-services/org.kde.drkonqi.service (sha256 file digest default filter:b99a6dc5943df0e641616dc4be3122fdd1d1b1c418df298c56008b50c5fb2b08 shell filter:b6f2a505903e2d8874d7da96a197944ab4a11f351f3db80ffeeec86d9eefd79a xml filter:<failed-to-calculate>)

https://build.opensuse.org/package/show/KDE:Frameworks/drkonqi6
Comment 11 Matthias Gerstner 2024-02-22 09:31:25 UTC
(In reply to christophe@krop.fr from comment #10)
> mmm... seems I forgot drkonqi6

can you please create a separate sub-bug for that and add it as a blocker for
this tracker bug? Thanks.
Comment 12 Matthias Gerstner 2024-02-23 09:35:40 UTC
Due to the issue identified in bug 1220215 we need to readjust all KDE6
whitelistings and the remaining whitelisting tasks are blocked until the new
kauth package is in place.

Please ping me once all affected packages build against the new kauth that
contains the bugfix.
Comment 13 Christophe Marin 2024-02-26 14:14:55 UTC
The staging project (https://build.opensuse.org/project/monitor/openSUSE:Factory:Staging:adi:26) reports some of the checksums added in https://build.opensuse.org/request/show/1147158 now mismatch

plasma6-disks:

E: dbus-file-digest-mismatch (Badness: 10000) /usr/share/dbus-1/system.d/org.kde.kded.smart.conf expected sha256:83b4e002b9bdab964dd49e9aacca5531e5b3f28c524f43b90de74020b05e90ce, has:5d237d26c933e2b8b525c666c0d1c97e76bdffbc123ec9896a4b726067fd2cad

libksysguard6:

dbus-file-digest-mismatch (Badness: 10000) /usr/share/dbus-1/system.d/org.kde.ksysguard.processlisthelper.conf expected sha256:e08be1fffd5b7ebddb31f396f603e7a9fac08784c5473f37195262b55c663d45, has:0eb5379a313fff2be98a64e5adbebffdb45ba5879a6434e7787f203334cf5785

kinfocenter6:

E: dbus-file-digest-mismatch (Badness: 10000) /usr/share/dbus-1/system.d/org.kde.kinfocenter.dmidecode.conf expected sha256:55400352c8d0450d3d4c1eeb8f009c2a2741a02b9ec5d3f8f1034644a7f9e2d2, has:6ac8b997890e65dc800e9106444f39c75c1b87416fd7ad4d82f05c0e9eae1aea
Comment 14 Christophe Marin 2024-02-26 14:21:19 UTC
and for kde-inotify-survey, we now have:

/usr/share/dbus-1/system-services/org.kde.kded.inotify.service expected sha256:89a2ce5a4c6ebd7cb471f820a28fbd2dd418e377cb2ed0eaea1af59840c1dabd, has:e56b75bc5cbaa9e4dfb5829dcb5c0d5d871c0533076b83ea2c0f363c00318ad4

/usr/share/dbus-1/system.d/org.kde.kded.inotify.conf expected sha256:4eb68f2c3bc75842df0f3d67874588fc672ec540769db09c3a71cbb292a989f7, has:7dd017f2535dabd623fdb59ecb6362ac60fa836e9a146243c2a450b04d9aee5d
Comment 15 Matthias Gerstner 2024-02-27 09:09:28 UTC
Yes that is to be expected, see bug 1220215. The adjusted checksums are
already on their way.
Comment 16 Matthias Gerstner 2024-07-05 12:41:22 UTC
With drkonqi the final whitelisting for KDE6 is through and we can close this
tracker.