Bug 1217393 - [Build 2.31] block vda: the capability attribute has been deprecated.
Summary: [Build 2.31] block vda: the capability attribute has been deprecated.
Status: VERIFIED FIXED
Alias: None
Product: PUBLIC SUSE Linux Enterprise Server 15 SP6
Classification: openSUSE
Component: Kernel (show other bugs)
Version: unspecified
Hardware: Other Other
: P4 - Low : Normal
Target Milestone: ---
Assignee: Kernel Bugs
QA Contact:
URL: https://openqa.suse.de/tests/12839254...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-11-22 11:44 UTC by Martin Loviska
Modified: 2024-03-06 08:10 UTC (History)
2 users (show)

See Also:
Found By: openQA
Services Priority:
Business Priority:
Blocker: Yes
Marketing QA Status: ---
IT Deployment: ---

Attachments
log (115.06 KB, text/x-log)
2023-11-22 11:44 UTC, Martin Loviska 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Loviska 2023-11-22 11:44:29 UTC 
Created attachment 870899 [details]
log

## Observation

openQA test in scenario sle-15-SP6-JeOS-for-kvm-and-xen-x86_64-jeos-ltp-syscalls@uefi-virtio-vga fails in
[journal_check](https://openqa.suse.de/tests/12839254/modules/journal_check/steps/11)

Test that scans journal for error or warning messages has detected following warning.

> [   12.822200] block vda: the capability attribute has been deprecated.

The VM was spawn with virtio-scsi-pci drives.

> -device virtio-scsi-pci,id=scsi0 -blockdev driver=file,node-name=hd0-overlay0-file,filename=/var/lib/openqa/pool/27/raid/hd0-overlay0,cache.no-flush=on -blockdev driver=qcow2,node-name=hd0-overlay0,file=hd0-overlay0-file,cache.no-flush=on,discard=unmap -device virtio-blk,id=hd0-device,drive=hd0-overlay0,bootindex=0,serial=hd0 -drive id=pflash-code-overlay0,if=pflash,file=/var/lib/openqa/pool/27/raid/pflash-code-overlay0,unit=0,readonly=on -drive id=pflash-vars-overlay0,if=pflash,file=/var/lib/openqa/pool/27/raid/pflash-vars-overlay0,unit=1

I haven't found any other related message nor failures related to this warning in our tests. Hence, I would like to have your confirmation that it is harmless, and we can whitelist it.

Thanks

## Reproducible

Fails since (at least) Build [2.15](https://openqa.suse.de/tests/12637835)


## Expected result

Last good: [2.6](https://openqa.suse.de/tests/12553981) (or more recent)


## Further details

Always latest result in this scenario: [latest](https://openqa.suse.de/tests/latest?arch=x86_64&distri=sle&flavor=JeOS-for-kvm-and-xen&machine=uefi-virtio-vga&test=jeos-ltp-syscalls&version=15-SP6)
Comment 1 Takashi Iwai 2023-11-22 11:53:22 UTC 
This is a change in 6.3

commit e81cd5a983bb35dabd38ee472cf3fea1c63e0f23
Author: Christoph Hellwig <hch@lst.de>
Date:   Fri Feb 3 16:02:09 2023 +0100

    block: stub out and deprecated the capability attribute on the gendisk
    
    The capability attribute was added in 2017 to expose the kernel internal
    GENHD_FL_MEDIA_CHANGE_NOTIFY to userspace without ever adding a value to
    an UAPI header, and without ever setting it in any driver until it was
    finally removed in Linux 5.7.
    
    Deprecate the file and always return 0 instead of exposing the other
    internal and frequently renumbered other gendisk flags.
    
    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
    Reviewed-by: Bart Van Assche <bvanassche@acm.org>
    Link: https://lore.kernel.org/r/20230203150209.3199115-1-hch@lst.de
    Signed-off-by: Jens Axboe <axboe@kernel.dk>

So it's just a message shown only once to indicate the deprecation.
Comment 2 Takashi Iwai 2024-01-16 14:14:43 UTC 
Closed as a FEATURE.
Comment 3 Martin Loviska 2024-03-06 08:10:17 UTC 
We not see the message anymore in the tests 
https://openqa.suse.de/tests/13713298#step/journal_check/8