Bug 1217732 - regression: cannot paste newlines into rxvt-unicode
Summary: regression: cannot paste newlines into rxvt-unicode
Status: IN_PROGRESS
Alias: None
Product: openSUSE Distribution
Classification: openSUSE
Component: X11 Applications (show other bugs)
Version: Leap 15.5
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Michal Suchanek
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-01 11:35 UTC by Michal Suchanek
Modified: 2024-02-24 20:05 UTC (History)
3 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
xterm paste (10.31 KB, image/png)
2023-12-01 11:35 UTC, Michal Suchanek
Details
xrvt-unicode paste (21.67 KB, image/png)
2023-12-01 11:36 UTC, Michal Suchanek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Suchanek 2023-12-01 11:35:54 UTC
Created attachment 871102 [details]
xterm paste

Newlines are lost when pasted into rxvt-unicode
Comment 1 Michal Suchanek 2023-12-01 11:36:19 UTC
Created attachment 871103 [details]
xrvt-unicode paste
Comment 2 Michal Suchanek 2023-12-01 11:48:05 UTC
Regression between 9.30-bp155.2.6 9.31-bp155.3.3.1
Comment 3 Michal Suchanek 2023-12-01 16:50:59 UTC
This is because rxvt-unicode added a 'sanitized paste' but made it the default paste rather than the new option /o\
Comment 4 Petr Vorel 2023-12-06 14:23:45 UTC
Michal, would you mind to tend your patch [1] to rxvt-unicode first? I would prefer not to diverge from upstream.

[1] https://build.opensuse.org/request/show/1131290
Comment 5 Michal Suchanek 2023-12-06 15:13:45 UTC
Upstream says: "just get over it, its trivial to override confirm-paste with a patch version that changes whatever you want"

In other words they don't care about breaking existing features :/
Comment 6 Petr Vorel 2023-12-06 20:38:19 UTC
I'm not sure if I'm really minority, who uses rxvt-unicode on more distros and expects to have pasting letters the same across distros. Fixing new line is obviously good idea, but I'm not so happy about changing letters (understand the reasons for the letters change, but without being accepted upstream it's not good).

> Upstream says: "just get over it, its trivial to override confirm-paste with a patch version that changes whatever you want"

Did you contact him privately? Or is there a public link? I'll probably try to discuss this with other distro maintainers (Debian, Ubuntu, Fedora, Arch Linux, Gentoo), so that I either use public discussion or OBS.
Comment 7 Michal Suchanek 2023-12-06 20:56:22 UTC
I don't know if the rxvt-unicode irc channel is logged.

Anyway, I think it's reasonable to discuss with distribution maintainers to avoid inconsistency as much as possible.

Clearly this is not a great move from upstream, and distributions carrying older version will be inconsistent with distributions carrying new version if nothing is done.
Comment 8 Petr Vorel 2023-12-11 20:03:43 UTC
(In reply to Michal Suchanek from comment #7)
> I don't know if the rxvt-unicode irc channel is logged.

No, r irc.libera.chat has no logs. It has mailing list [1].

> 
> Anyway, I think it's reasonable to discuss with distribution maintainers to
> avoid inconsistency as much as possible.

Yep, I'll write several maintainers (Debian, Fedora, Arch Linux) and Cc you.
IMHO best would be to agree on the patch and then send it with others in Cc who would support the change.

> Clearly this is not a great move from upstream, and distributions carrying
> older version will be inconsistent with distributions carrying new version
> if nothing is done.

Yep, I still hope we would come with a single patch in upstream.

[1] http://lists.schmorp.de/pipermail/rxvt-unicode/
Comment 9 Petr Vorel 2024-01-01 17:08:41 UTC
I see regardless my concern here about diverging keyboard shortcut from upstream (and thus from all distros) SR#1135993 [1] was accepted. I still don't think it's a good idea to diverge keyboard shortcut (I agree on fixing pasting) but I will not block it.


[1] https://build.opensuse.org/request/show/1135993
Comment 10 Chenzi Cao 2024-01-25 15:36:21 UTC
The request has been accepted, I assign it to Michal who submitted the request, I suppose the issue is resolved and can be close now.
Comment 11 Michal Suchanek 2024-01-25 16:16:18 UTC
Submitted update to 15.5 and 15.6

In 15.4 the broken version has been released as an update but it does not seem to accept updates anymore.
Comment 12 Marcus Meissner 2024-02-24 20:05:23 UTC
openSUSE-RU-2024:0059-1: An update that has two recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1214136,1217732
CVE References: 
JIRA References: 
Sources used:
openSUSE Backports SLE-15-SP5 (src):    rxvt-unicode-9.31-bp155.3.6.1