Bug 1218451 - bison: clarify parameter declaration
Summary: bison: clarify parameter declaration
Status: NEW
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Development (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Michael Matz
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-29 12:53 UTC by Michal Suchanek
Modified: 2024-01-08 17:14 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments
proposed patch (927 bytes, patch)
2023-12-29 12:53 UTC, Michal Suchanek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Suchanek 2023-12-29 12:53:09 UTC
Created attachment 871602 [details]
proposed patch

Patch clarifying parameter declarations.
Comment 1 Richard Biener 2024-01-08 09:58:07 UTC
upstream?
Comment 2 Michal Suchanek 2024-01-08 12:24:00 UTC
Have not done the paperwork for talking to GNU upstream.
Comment 3 Michael Matz 2024-01-08 16:20:26 UTC
Doesn't this already follow from the use of singular form in

   Directive: %parse-param {ARGUMENT-DECLARATION} ...

and the example that uses two arguments with separate braces:

   %parse-param {int *nastiness} {int *randomness}

?  I guess being more explicit doesn't hurt, though.
Comment 4 Michal Suchanek 2024-01-08 17:11:55 UTC
It's kind of 'if you know how it is you can see it there' thing.

As in if you have no idea how it's implemented internally it's not clear at all.
Comment 5 Michal Suchanek 2024-01-08 17:14:32 UTC
The other option would be bison refusing multiple arguments in one %parse-param but it does not. Documenting the deficiency sounds easier than fixing it.