Bug 1219527 - abcde breaks on non-octal track numbers
Summary: abcde breaks on non-octal track numbers
Status: IN_PROGRESS
Alias: None
Product: openSUSE Distribution
Classification: openSUSE
Component: Other (show other bugs)
Version: Leap 15.5
Hardware: x86-64 openSUSE Leap 15.5
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Martin Wilck
QA Contact: E-mail List
URL: https://abcde.einval.com/bugzilla/sho...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-03 23:01 UTC by Geoff Kuenning
Modified: 2024-04-29 09:56 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Patch to /usr/bin/abcde (592 bytes, patch)
2024-02-03 23:01 UTC, Geoff Kuenning 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoff Kuenning 2024-02-03 23:01:52 UTC 
Created attachment 872425 [details]
Patch to /usr/bin/abcde

abcde pads track numbers with a leading zero but later does some bash arithmetic on the track number.  That breaks for track numbers 8 and 9, because 09 isn't an octal number.

Reproduce by inserting an 8+ track CD and running "abcde -T 1 8-8".

The attached patch will correct the problem for any CD having 99 or fewer tracks.  (As far as I know, 99 is the track limit for CDs, though I definitely could be wrong.)
Comment 1 Martin Wilck 2024-04-16 15:51:16 UTC 
Has this been reported upstream?

https://abcde.einval.com/bugzilla/
Comment 2 Geoff Kuenning 2024-04-17 07:06:17 UTC 
As far as I know it hasn't been reported upstream.
Comment 3 Martin Wilck 2024-04-17 15:46:14 UTC 
Would you mind doing that?
Comment 4 Geoff Kuenning 2024-04-17 18:09:41 UTC 
Done. (I had more time today than I expected!)
Comment 5 Martin Wilck 2024-04-17 18:37:35 UTC 
FTR, https://abcde.einval.com/bugzilla/show_bug.cgi?id=204
Comment 6 Martin Wilck 2024-04-17 18:38:02 UTC 
Thanks, let's see what upstream says.
Comment 7 Martin Wilck 2024-04-29 09:56:29 UTC 
It seems that upstream is silent...