Bug 1220481 - GCC 14: gamin package fails
Summary: GCC 14: gamin package fails
Status: RESOLVED FIXED
: 1224897 (view as bug list)
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Jan Engelhardt
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: modern_C
  Show dependency treegraph
 
Reported: 2024-02-27 15:58 UTC by Michal Jireš
Modified: 2024-07-08 15:46 UTC (History)
3 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Jireš 2024-02-27 15:58:11 UTC
Building gamin with GCC 14 fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/gamin/standard/x86_64

Due to:

gam_listener.c: In function ‘gam_listener_free_subscription’:
gam_listener.c:101:39: error: implicit declaration of function ‘gam_exclude_check’; did you mean ‘gam_error_check’? [-Wimplicit-function-declaration]
  101 |     if (gam_inotify_is_running() && (!gam_exclude_check(path))) {
      |                                       ^~~~~~~~~~~~~~~~~
      |                                       gam_error_check
gam_node.c: In function ‘gam_node_emit_event’:
gam_node.c:375:9: error: implicit declaration of function ‘gam_server_emit_event’; did you mean ‘gam_node_emit_event’? [-Wimplicit-function-declaration]
  375 |         gam_server_emit_event(gam_node_get_path(node), is_dir_node, event, subs, 0);
      |         ^~~~~~~~~~~~~~~~~~~~~
      |         gam_node_emit_event
gam_server.c: In function ‘gam_init_subscriptions’:
gam_server.c:167:13: error: implicit declaration of function ‘gam_poll_basic_init’; did you mean ‘gam_poll_generic_init’? [-Wimplicit-function-declaration]
  167 |         if (gam_poll_basic_init()) {
      |             ^~~~~~~~~~~~~~~~~~~
      |             gam_poll_generic_init

gam_inotify.c: In function ‘gam_inotify_init’:
gam_inotify.c:145:9: error: implicit declaration of function ‘gam_poll_basic_init’ [-Wimplicit-function-declaration]
  145 |         gam_poll_basic_init ();
      |         ^~~~~~~~~~~~~~~~~~~
gam_connection.c: In function ‘gam_connection_request’:
gam_connection.c:402:49: error: implicit declaration of function ‘gam_exclude_check’; did you mean ‘gam_error_check’? [-Wimplicit-function-declaration]
  402 |             if ((gam_inotify_is_running()) && (!gam_exclude_check(path))) {
      |                                                 ^~~~~~~~~~~~~~~~~
      |                                                 gam_error_check


Builds with:

Index: gamin.spec_dir/gamin-0.1.10/server/gam_listener.c
===================================================================
--- gamin.spec_dir.orig/gamin-0.1.10/server/gam_listener.c
+++ gamin.spec_dir/gamin-0.1.10/server/gam_listener.c
@@ -27,6 +27,7 @@
 #include "gam_pidname.h"
 #ifdef ENABLE_INOTIFY
 #include "gam_inotify.h"
+#include "gam_excludes.h"
 #endif

 //#define GAM_LISTENER_VERBOSE
Index: gamin.spec_dir/gamin-0.1.10/server/gam_node.c
===================================================================
--- gamin.spec_dir.orig/gamin-0.1.10/server/gam_node.c
+++ gamin.spec_dir/gamin-0.1.10/server/gam_node.c
@@ -23,6 +23,7 @@
 #include "gam_event.h"
 #include "gam_node.h"
 #include "gam_error.h"
+#include "gam_server.h"

 /**
  * Create a new node
Index: gamin.spec_dir/gamin-0.1.10/server/gam_server.c
===================================================================
--- gamin.spec_dir.orig/gamin-0.1.10/server/gam_server.c
+++ gamin.spec_dir/gamin-0.1.10/server/gam_server.c
@@ -33,6 +33,7 @@
 #include "gam_channel.h"
 #include "gam_subscription.h"
 #include "gam_poll_generic.h"
+#include "gam_poll_basic.h"
 #ifdef ENABLE_INOTIFY
 #include "gam_inotify.h"
 #endif
Index: gamin.spec_dir/gamin-0.1.10/server/gam_connection.c
===================================================================
--- gamin.spec_dir.orig/gamin-0.1.10/server/gam_connection.c
+++ gamin.spec_dir/gamin-0.1.10/server/gam_connection.c
@@ -17,6 +17,7 @@
 #endif
 #ifdef ENABLE_INOTIFY
 #include "gam_inotify.h"
+#include "gam_excludes.h"
 #endif
 #include "fam.h"

Index: gamin.spec_dir/gamin-0.1.10/server/gam_inotify.c
===================================================================
--- gamin.spec_dir.orig/gamin-0.1.10/server/gam_inotify.c
+++ gamin.spec_dir/gamin-0.1.10/server/gam_inotify.c
@@ -30,6 +30,7 @@
 #include "gam_server.h"
 #include "gam_subscription.h"
 #include "gam_inotify.h"
+#include "gam_poll_basic.h"

 /* Transforms a inotify event to a gamin event. */
 static GaminEventType
Comment 1 Martin Jambor 2024-05-31 19:25:54 UTC
*** Bug 1224897 has been marked as a duplicate of this bug. ***
Comment 2 Martin Jambor 2024-07-08 15:46:53 UTC
This has been fixed with https://build.opensuse.org/package/rdiff/openSUSE:Factory/gamin?linkrev=base&rev=16