Bug 1221057 (CVE-2024-26623) - VUL-0: CVE-2024-26623: kernel: pds_core: Prevent race issues involving the adminq
Summary: VUL-0: CVE-2024-26623: kernel: pds_core: Prevent race issues involving the ad...
Status: NEW
Alias: CVE-2024-26623
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/396465/
Whiteboard: CVSSv3.1:SUSE:CVE-2024-26623:5.5:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-06 12:58 UTC by SMASH SMASH
Modified: 2024-07-03 09:57 UTC (History)
4 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-03-06 12:58:40 UTC
In the Linux kernel, the following vulnerability has been resolved:

pds_core: Prevent race issues involving the adminq

There are multiple paths that can result in using the pdsc's
adminq.

[1] pdsc_adminq_isr and the resulting work from queue_work(),
    i.e. pdsc_work_thread()->pdsc_process_adminq()

[2] pdsc_adminq_post()

When the device goes through reset via PCIe reset and/or
a fw_down/fw_up cycle due to bad PCIe state or bad device
state the adminq is destroyed and recreated.

A NULL pointer dereference can happen if [1] or [2] happens
after the adminq is already destroyed.

In order to fix this, add some further state checks and
implement reference counting for adminq uses. Reference
counting was used because multiple threads can attempt to
access the adminq at the same time via [1] or [2]. Additionally,
multiple clients (i.e. pds-vfio-pci) can be using [2]
at the same time.

The adminq_refcnt is initialized to 1 when the adminq has been
allocated and is ready to use. Users/clients of the adminq
(i.e. [1] and [2]) will increment the refcnt when they are using
the adminq. When the driver goes into a fw_down cycle it will
set the PDSC_S_FW_DEAD bit and then wait for the adminq_refcnt
to hit 1. Setting the PDSC_S_FW_DEAD before waiting will prevent
any further adminq_refcnt increments. Waiting for the
adminq_refcnt to hit 1 allows for any current users of the adminq
to finish before the driver frees the adminq. Once the
adminq_refcnt hits 1 the driver clears the refcnt to signify that
the adminq is deleted and cannot be used. On the fw_up cycle the
driver will once again initialize the adminq_refcnt to 1 allowing
the adminq to be used again.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-26623
https://www.cve.org/CVERecord?id=CVE-2024-26623
https://git.kernel.org/stable/c/22cd6046eb2148b18990257505834dd45c672a1b
https://git.kernel.org/stable/c/5939feb63ea1f011027576c64b68b681cbad31ca
https://git.kernel.org/stable/c/7e82a8745b951b1e794cc780d46f3fbee5e93447
Comment 2 Oscar Salvador 2024-04-16 04:50:14 UTC
@Denis: Can you please have a look?

./scripts/check-kernel-fix CVE-2024-26623
7e82a8745b95 ("pds_core: Prevent race issues involving the adminq") merged v6.8-rc3~26^2~13^2~2
Fixes: 01ba61b55b20 ("pds_core: Add adminq processing and commands") merged v6.4-rc1~132^2~34^2~8
Security fix for CVE-2024-26623 bsc#1221057 with CVSS 5.5
..............................
ACTION NEEDED!
SLE15-SP6: MANUAL: backport 7e82a8745b951b1e794cc780d46f3fbee5e93447 (Fixes 01ba61b55b20)