Bug 1221079 (CVE-2023-52584) - VUL-0: CVE-2023-52584: kernel: spmi: mediatek: Fix UAF on device remove
Summary: VUL-0: CVE-2023-52584: kernel: spmi: mediatek: Fix UAF on device remove
Status: RESOLVED FIXED
Alias: CVE-2023-52584
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/396441/
Whiteboard: CVSSv3.1:SUSE:CVE-2023-52584:5.3:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-06 15:39 UTC by SMASH SMASH
Modified: 2024-06-25 18:19 UTC (History)
2 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-03-06 15:39:11 UTC
In the Linux kernel, the following vulnerability has been resolved:

spmi: mediatek: Fix UAF on device remove

The pmif driver data that contains the clocks is allocated along with
spmi_controller.
On device remove, spmi_controller will be freed first, and then devres
, including the clocks, will be cleanup.
This leads to UAF because putting the clocks will access the clocks in
the pmif driver data, which is already freed along with spmi_controller.

This can be reproduced by enabling DEBUG_TEST_DRIVER_REMOVE and
building the kernel with KASAN.

Fix the UAF issue by using unmanaged clk_bulk_get() and putting the
clocks before freeing spmi_controller.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-52584
https://www.cve.org/CVERecord?id=CVE-2023-52584
https://lore.kernel.org/linux-cve-announce/2024030643-CVE-2023-52584-fb9a@gregkh/

Patch:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e821d50ab5b9
Comment 1 Andrea Mattiazzo 2024-03-06 15:42:55 UTC
Already patched:
-stable
-SLE15-SP6

@kernel-bugs could you add the CVE reference?
Comment 11 Ivan Ivanov 2024-04-12 14:32:22 UTC
Driver is first enabled/compiled in SLE15-SP6. 
No affected branches. Back to secutiry team.
Comment 12 Andrea Mattiazzo 2024-04-16 12:33:43 UTC
Closing