Bug 1221904 - Patch grub2-pass-corret-root-for-nfsroot.patch is using the wrong order of GRUB_FS/GRUB_DEVICE
Summary: Patch grub2-pass-corret-root-for-nfsroot.patch is using the wrong order of GR...
Status: NEW
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Bootloader (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Michael Chang
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-24 12:41 UTC by Andrei Borzenkov
Modified: 2024-03-25 01:57 UTC (History)
0 users

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Borzenkov 2024-03-24 12:41:45 UTC 
Patch grub2-pass-corret-root-for-nfsroot.patch results in grub-mkconfig probing for GRUB_DEVICE after the first use in probing for GRUB_FS.

    # Filesystem for the device containing our userland.  Used for stuff like
    # choosing Hurd filesystem module.
    GRUB_FS="`${grub_probe} --device ${GRUB_DEVICE} --target=fs 2> /dev/null || echo unknown`"
    # Device containing our userland.  Typically used for root= parameter.
    GRUB_DEVICE="`${grub_probe} --target=device /`"

It makes probing for GRUB_FS fail which went unnoticed because grub-mkconfig falls back to using `stat -f`. Until at least one user hit weird problem with `stat -f` failing to report `btrfs` filesystem type.

See the details in

https://forums.opensuse.org/t/boot-from-snapshots-missing-from-grub-menu/173485/29
Comment 1 Michael Chang 2024-03-25 01:57:19 UTC 
Thanks for pointing this out. And I'm sincerely sorry for the mistake and the trouble it leads to, this shouldn't happen in the first place. :(
I'm going to update grub2 to fix the issue.