Bug 1222299 (CVE-2023-52638) - VUL-0: CVE-2023-52638: kernel: can: j1939: prevent deadlock by changing j1939_socks_lock to rwlock
Summary: VUL-0: CVE-2023-52638: kernel: can: j1939: prevent deadlock by changing j1939...
Status: IN_PROGRESS
Alias: CVE-2023-52638
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Denis Kirjanov
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/400153/
Whiteboard: CVSSv3.1:SUSE:CVE-2023-52638:5.5:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-04 09:30 UTC by SMASH SMASH
Modified: 2024-06-25 18:24 UTC (History)
2 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-04-04 09:30:57 UTC
In the Linux kernel, the following vulnerability has been resolved:

can: j1939: prevent deadlock by changing j1939_socks_lock to rwlock

The following 3 locks would race against each other, causing the
deadlock situation in the Syzbot bug report:

- j1939_socks_lock
- active_session_list_lock
- sk_session_queue_lock

A reasonable fix is to change j1939_socks_lock to an rwlock, since in
the rare situations where a write lock is required for the linked list
that j1939_socks_lock is protecting, the code does not attempt to
acquire any more locks. This would break the circular lock dependency,
where, for example, the current thread already locks j1939_socks_lock
and attempts to acquire sk_session_queue_lock, and at the same time,
another thread attempts to acquire j1939_socks_lock while holding
sk_session_queue_lock.

NOTE: This patch along does not fix the unregister_netdevice bug
reported by Syzbot; instead, it solves a deadlock situation to prepare
for one or more further patches to actually fix the Syzbot bug, which
appears to be a reference counting problem within the j1939 codebase.

[mkl: remove unrelated newline change]

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-52638
https://git.kernel.org/stable/c/6cdedc18ba7b9dacc36466e27e3267d201948c8d
https://git.kernel.org/stable/c/aedda066d717a0b4335d7e0a00b2e3a61e40afcf
https://www.cve.org/CVERecord?id=CVE-2023-52638
https://git.kernel.org/stable/c/03358aba991668d3bb2c65b3c82aa32c36851170
https://git.kernel.org/stable/c/26dfe112ec2e95fe0099681f6aec33da13c2dd8e
https://git.kernel.org/stable/c/559b6322f9480bff68cfa98d108991e945a4f284
https://bugzilla.redhat.com/show_bug.cgi?id=2273082
Comment 4 Oscar Salvador 2024-04-17 03:48:29 UTC
@Denis: Can you please check

./scripts/check-kernel-fix CVE-2023-52638
6cdedc18ba7b ("can: j1939: prevent deadlock by changing j1939_socks_lock to rwlock") merged v6.8-rc5~28^2~7^2~2
Security fix for CVE-2023-52638 bsc#1222299 with CVSS 5.5
..............................
ACTION NEEDED!
SLE15-SP5: MANUAL: might need backport of 6cdedc18ba7b9dacc36466e27e3267d201948c8d ()
SLE12-SP5: MANUAL: might need backport of 6cdedc18ba7b9dacc36466e27e3267d201948c8d ()
SLE12-SP3-TD: MANUAL: might need backport of 6cdedc18ba7b9dacc36466e27e3267d201948c8d (