Bug 1222462 (CVE-2024-26690) - VUL-0: CVE-2024-26690: kernel: net: stmmac: protect updates of 64-bit statistics counters
Summary: VUL-0: CVE-2024-26690: kernel: net: stmmac: protect updates of 64-bit statist...
Status: RESOLVED FIXED
Alias: CVE-2024-26690
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P5 - None : Normal
Target Milestone: ---
Assignee: Kernel Bugs
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/400163/
Whiteboard: CVSSv3.1:SUSE:CVE-2024-26690:5.5:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-08 12:17 UTC by SMASH SMASH
Modified: 2024-04-08 12:23 UTC (History)
1 user (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-04-08 12:17:44 UTC
In the Linux kernel, the following vulnerability has been resolved:

net: stmmac: protect updates of 64-bit statistics counters

As explained by a comment in <linux/u64_stats_sync.h>, write side of struct
u64_stats_sync must ensure mutual exclusion, or one seqcount update could
be lost on 32-bit platforms, thus blocking readers forever. Such lockups
have been observed in real world after stmmac_xmit() on one CPU raced with
stmmac_napi_poll_tx() on another CPU.

To fix the issue without introducing a new lock, split the statics into
three parts:

1. fields updated only under the tx queue lock,
2. fields updated only during NAPI poll,
3. fields updated only from interrupt context,

Updates to fields in the first two groups are already serialized through
other locks. It is sufficient to split the existing struct u64_stats_sync
so that each group has its own.

Note that tx_set_ic_bit is updated from both contexts. Split this counter
so that each context gets its own, and calculate their sum to get the total
value in stmmac_get_ethtool_stats().

For the third group, multiple interrupts may be processed by different CPUs
at the same time, but interrupts on the same CPU will not nest. Move fields
from this group to a newly created per-cpu struct stmmac_pcpu_stats.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-26690
https://www.cve.org/CVERecord?id=CVE-2024-26690
https://git.kernel.org/stable/c/38cc3c6dcc09dc3a1800b5ec22aef643ca11eab8
https://git.kernel.org/stable/c/9680b2ab54ba8d72581100e8c45471306101836e
https://git.kernel.org/stable/c/e6af0f082a4b87b99ad033003be2a904a1791b3f
https://bugzilla.redhat.com/show_bug.cgi?id=2273100
Comment 1 Robert Frohl 2024-04-08 12:23:24 UTC
does not affect SUSE kernels, closing