Bug 1222932 - power-profiles-daemon fails to build on Leap 15.6 - fail in test_dytc_performance_driver
Summary: power-profiles-daemon fails to build on Leap 15.6 - fail in test_dytc_perfor...
Status: NEW
Alias: None
Product: openSUSE Distribution
Classification: openSUSE
Component: Other (show other bugs)
Version: Leap 15.6
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Atri Bhattacharya
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-16 22:26 UTC by Lubos Kocman
Modified: 2024-05-21 03:57 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---
badshah400: SHIP_STOPPER?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Lubos Kocman 2024-04-16 22:26:28 UTC
Hello 

package power-profiles-daemon fails to build on Leap 15.6

https://build.opensuse.org/package/live_build_log/openSUSE:Backports:SLE-15-SP6/power-profiles-daemon/standard/x86_64


[   37s] ** (power-profiles-daemon:2094): DEBUG: 10:23:07.358: /sys/firmware/acpi/platform_profile changed (2)
[   37s] ** (power-profiles-daemon:2094): DEBUG: 10:23:07.358: Failed to get contents for '/tmp/umockdev.F1WVL2/sys/firmware/acpi/platform_profile': Failed to open file “/tmp/umockdev.F1WVL2/sys/firmware/acpi/platform_profile”: No such file or directory
[   37s] ------------------------------
[   37s] 
[   37s] ======================================================================
[   37s] FAIL: test_dytc_performance_driver (__main__.Tests)
[   37s] Lenovo DYTC performance driver
[   37s] ----------------------------------------------------------------------
[   37s] Traceback (most recent call last):
[   37s]   File "/home/abuild/rpmbuild/BUILD/power-profiles-daemon-0.13/x86_64-suse-linux/../tests/integration-test.py", line 803, in test_dytc_performance_driver
[   37s]     self.assertEventually(lambda: self.get_dbus_property('PerformanceDegraded') == 'lap-detected')
[   37s]   File "/home/abuild/rpmbuild/BUILD/power-profiles-daemon-0.13/x86_64-suse-linux/../tests/integration-test.py", line 293, in assertEventually
[   37s]     self.fail(message or 'timed out waiting for ' + str(condition))
[   37s] AssertionError: timed out waiting for <function Tests.test_dytc_performance_driver.<locals>.<lambda> at 0x7fd2e27c1378>
[   37s] 
[   37s] ----------------------------------------------------------------------
[   37s] Ran 1 test in 5.437s
[   37s] 
[   37s] FAILED (failures=1)
[   37s] ――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――
[   37s] 
[   37s] 29/31 Tests.test_trickle_charge_mode_no_change OK              0.43s
[   37s] 30/31 Tests.test_trickle_charge_system         OK              0.44s
[   38s] 31/31 Tests.test_vanishing_hold                OK              1.45s

Could you please have a look?
Comment 1 Atri Bhattacharya 2024-04-17 04:30:31 UTC
This is due to some recent systemd updates to SLE-15-SP6, no doubt. Anyway, the thing that will fix this properly is an update to umockdev 0.18.1 from Factory. I already tested this theory out in my home branch where I built the SLE-15-SP6 power-profiles-daemon against Factory's umockdev:
https://build.opensuse.org/project/show/home:badshah400:branches:openSUSE:Backports:SLE-15-SP6

How should I submit a new umockdev version at this stage, and is there any chance of such an update being accepted?
Comment 2 Atri Bhattacharya 2024-04-26 13:22:11 UTC
I guess this fixed itself? Even otherwise, it seems it is already too late now. FYI the fix is to upgrade umockdev to 0.18.1.

I am sorry, I find contributing to Leap almost impossible given its Frankenstein's monster nature. Still, I tried to help as much as I could.
Comment 3 Atri Bhattacharya 2024-04-28 14:51:25 UTC
I don't know if this is the right target, but a potential fix is to upgrade umockdev to 0.17.18 (without jumping two minor versions to 0.18.x in Factory) which also fixed the power-profiles-daemon build. Here is the sr:

https://build.opensuse.org/request/show/1170592

Raising the ship_stopper flag given that power-profiles-daemon forms a core part of the GNOME desktop env.
Comment 4 Lubos Kocman 2024-05-06 09:19:11 UTC
I've raised the issue with GNOME team. 

We'd have to update umockdev in SLES 15, I'd suggest SP4:Update + some sort of ECO as the SP6:GA accepts P1/P2s and this issue is basically not present in SLES (although the fix lands there). Of course we could try SP6 first ...

Yi Fan what do you think?
Comment 5 Yifan Jiang 2024-05-06 09:33:51 UTC
(In reply to Lubos Kocman from comment #4)
> I've raised the issue with GNOME team. 
> 
> We'd have to update umockdev in SLES 15, I'd suggest SP4:Update + some sort
> of ECO as the SP6:GA accepts P1/P2s and this issue is basically not present
> in SLES (although the fix lands there). Of course we could try SP6 first ...
> 
> Yi Fan what do you think?

The updating of umockdev seems nontrivial, and at least the impacted areas will be fwupd, udev, power-profiles-daemon. So for SP6, I am afraid we can't get it in GA.

Just to clarify - is there any reason we need that in SP4? If it is caused by the forked systemd on SP6, shouldn't the update happens on SP6:Update through ECO?
Comment 6 Lubos Kocman 2024-05-06 11:04:22 UTC
well SP6:Update is also an option for sure. The only reason for SP4:Update was to simply update it when its forked and keep amount of forks minimal. Nothing else.
Comment 7 Lubos Kocman 2024-05-06 11:09:01 UTC
https://jira.suse.com/browse/PED-8351
Comment 8 Lubos Kocman 2024-05-06 11:27:28 UTC
MR https://build.suse.de/request/show/328919
Comment 9 Lubos Kocman 2024-05-06 11:31:06 UTC
Proposed fork for Leap 15.6 https://build.opensuse.org/request/show/1172156
Comment 10 Atri Bhattacharya 2024-05-06 12:30:13 UTC
(In reply to Lubos Kocman from comment #9)
> Proposed fork for Leap 15.6 https://build.opensuse.org/request/show/1172156

Awesome, thanks for the help.