Bug 1222962 (CVE-2024-26818) - VUL-0: CVE-2024-26818: kernel: tools/rtla: Fix clang warning about mount_point var size
Summary: VUL-0: CVE-2024-26818: kernel: tools/rtla: Fix clang warning about mount_poin...
Status: RESOLVED FIXED
Alias: CVE-2024-26818
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/402305/
Whiteboard: CVSSv3.1:SUSE:CVE-2024-26818:4.4:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-17 12:30 UTC by SMASH SMASH
Modified: 2024-05-29 12:26 UTC (History)
3 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-04-17 12:30:09 UTC
In the Linux kernel, the following vulnerability has been resolved:

tools/rtla: Fix clang warning about mount_point var size

clang is reporting this warning:

$ make HOSTCC=clang CC=clang LLVM_IAS=1
[...]
clang -O -g -DVERSION=\"6.8.0-rc3\" -flto=auto -fexceptions
	-fstack-protector-strong -fasynchronous-unwind-tables
	-fstack-clash-protection  -Wall -Werror=format-security
	-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS
	$(pkg-config --cflags libtracefs)    -c -o src/utils.o src/utils.c

src/utils.c:548:66: warning: 'fscanf' may overflow; destination buffer in argument 3 has size 1024, but the corresponding specifier may require size 1025 [-Wfortify-source]
  548 |         while (fscanf(fp, "%*s %" STR(MAX_PATH) "s %99s %*s %*d %*d\n", mount_point, type) == 2) {
      |                                                                         ^

Increase mount_point variable size to MAX_PATH+1 to avoid the overflow.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-26818
https://www.cve.org/CVERecord?id=CVE-2024-26818
https://git.kernel.org/stable/c/30369084ac6e27479a347899e74f523e6ca29b89
https://git.kernel.org/stable/c/6bdd43f62ab3bb5a306af7f0ab857af45777f5a8
https://git.kernel.org/stable/c/8a585914c266dc044f53b5c83c170f79b45fcf9a
https://git.kernel.org/pub/scm/linux/security/vulns.git/plain/cve/published/2024/CVE-2024-26818.mbox
Comment 1 Michal Hocko 2024-04-17 12:42:08 UTC
The CVE seems completely bogus here. I fail to see how any attacker can shape the content of /proc/mounts without already owning the machine one way or the other.
Comment 3 Andrea Mattiazzo 2024-05-29 12:26:31 UTC
All done, closing.