Bug 1223008 (CVE-2024-26831) - VUL-0: CVE-2024-26831: kernel: net/handshake: Fix handshake_req_destroy_test1
Summary: VUL-0: CVE-2024-26831: kernel: net/handshake: Fix handshake_req_destroy_test1
Status: RESOLVED FIXED
Alias: CVE-2024-26831
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/402319/
Whiteboard: CVSSv3.1:SUSE:CVE-2024-26831:3.3:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-18 07:07 UTC by SMASH SMASH
Modified: 2024-07-03 13:39 UTC (History)
3 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-04-18 07:07:17 UTC
In the Linux kernel, the following vulnerability has been resolved:

net/handshake: Fix handshake_req_destroy_test1

Recently, handshake_req_destroy_test1 started failing:

Expected handshake_req_destroy_test == req, but
    handshake_req_destroy_test == 0000000000000000
    req == 0000000060f99b40
not ok 11 req_destroy works

This is because "sock_release(sock)" was replaced with "fput(filp)"
to address a memory leak. Note that sock_release() is synchronous
but fput() usually delays the final close and clean-up.

The delay is not consequential in the other cases that were changed
but handshake_req_destroy_test1 is testing that handshake_req_cancel()
followed by closing the file actually does call the ->hp_destroy
method. Thus the PTR_EQ test at the end has to be sure that the
final close is complete before it checks the pointer.

We cannot use a completion here because if ->hp_destroy is never
called (ie, there is an API bug) then the test will hang.

Reported by: Guenter Roeck <linux@roeck-us.net>

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-26831
https://www.cve.org/CVERecord?id=CVE-2024-26831
https://git.kernel.org/stable/c/4e1d71cabb19ec2586827adfc60d68689c68c194
https://git.kernel.org/stable/c/7f97805b8df6e33850e225e6bd3ebd9e246920af
https://git.kernel.org/stable/c/d74226e03df1bf19848f18344401f254345af912
https://git.kernel.org/pub/scm/linux/security/vulns.git/plain/cve/published/2024/CVE-2024-26831.mbox
https://bugzilla.redhat.com/show_bug.cgi?id=2275593
Comment 1 Oscar Salvador 2024-04-19 13:37:55 UTC
@Michal: Can you please check
Comment 3 Andrea Mattiazzo 2024-07-03 13:39:34 UTC
All done, closing.