Bug 1223839 - git 2.45.0 requires some python module tests fixes
Summary: git 2.45.0 requires some python module tests fixes
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: Python (show other bugs)
Version: Current
Hardware: Other Other
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Python maintainers (group account)
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-03 09:58 UTC by Ana Guerrero
Modified: 2024-05-06 17:46 UTC (History)
1 user (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ana Guerrero 2024-05-03 09:58:48 UTC
New git  2.45.0 (SR#1171274) makes, at least, the tests of 2 python packages to fail:

python-setuptools_scm:test

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:L/python-setuptools_scm:test/standard/x86_64

python-hatch_vcs:test

https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:L/python-hatch_vcs:test/standard/x86_64


Maybe there are others affected packages but they're not in a ring.
Comment 1 Andreas Stieger 2024-05-03 11:03:09 UTC
From https://raw.githubusercontent.com/git/git/master/Documentation/RelNotes/2.45.0.txt

>  * The output format for dates "iso-strict" has been tweaked to show
>    a time in the Zulu timezone with "Z" suffix, instead of "+00:00".

https://github.com/git/git/commit/69e2bee1a3ba2f9367d55992f401e6365be100ea

> Subject: [PATCH] date: make "iso-strict" conforming for the UTC timezone
> 
> ISO 8601-1:2020-12 specifies that a zero timezone offset must be denoted
> with a "Z" suffix instead of the numeric "+00:00". Add the correponding
> special case to show_date() and a new test.
> 
> Changing an established output format which might be depended on by
> scripts is always problematic, but here we choose to adhere more closely
> to the published standard.
Comment 2 Andreas Stieger 2024-05-03 11:10:54 UTC
python 3.10 https://docs.python.org/3.10/library/datetime.html#datetime.datetime.fromisoformat

> Caution
> 
> This does not support parsing arbitrary ISO 8601 strings - it is only intended 
> as the inverse operation of datetime.isoformat(). A more full-featured ISO 8601
> parser, dateutil.parser.isoparse is available in the third-party package dateutil.

Specifically this version cannot parse the Z suffix.

python 3.11:

https://docs.python.org/3.11/library/datetime.html#datetime.datetime.fromisoformat

> Changed in version 3.11: Previously, this method only supported formats that could be
> emitted by date.isoformat() or datetime.isoformat().
Comment 3 Andreas Stieger 2024-05-03 11:15:17 UTC
https://github.com/pypa/setuptools_scm/issues/1038
Comment 4 Andreas Stieger 2024-05-03 18:31:30 UTC
python-setuptools_scm: https://build.opensuse.org/request/show/1171838
Comment 5 Andreas Stieger 2024-05-03 18:49:45 UTC
And that seems to be the only change needed, as the other failure is transient.
Comment 6 Andreas Stieger 2024-05-06 17:46:07 UTC
openSUSE:Factory:Staging:E seems fine, closing