Bug 1224289 - VUL-0: CVE-2024-4068: cockpit,cockpit-agama,cockpit-machines,cockpit-podman,cockpit-tukit: the npm package `braces` fails to limit the number of characters it can handle, which could lead to Memory Exhaustion
Summary: VUL-0: CVE-2024-4068: cockpit,cockpit-agama,cockpit-machines,cockpit-podman,c...
Status: RESOLVED UPSTREAM
Alias: None
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Minor
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/405385/
Whiteboard: CVSSv3.1:SUSE:CVE-2024-4068:7.5:(AV:N...
Keywords:
Depends on:
Blocks: CVE-2024-4068
  Show dependency tree / graph
 
Reported: 2024-05-15 11:34 UTC by SMASH SMASH
Modified: 2024-05-16 13:44 UTC (History)
4 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-05-15 11:34:08 UTC 
The NPM package `braces` fails to limit the number of characters it can handle, which could lead to Memory Exhaustion. In `lib/parse.js,` if a malicious user sends "imbalanced braces" as input, the parsing will enter a loop, which will cause the program to start allocating heap memory without freeing it at any moment of the loop. Eventually, the JavaScript heap limit is reached, and the program will crash.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-4068
https://www.cve.org/CVERecord?id=CVE-2024-4068
https://devhub.checkmarx.com/cve-details/CVE-2024-4068/
https://github.com/micromatch/braces/blob/98414f9f1fabe021736e26836d8306d5de747e0d/lib/parse.js#L308
https://github.com/micromatch/braces/issues/35

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-4068
https://www.cve.org/CVERecord?id=CVE-2024-4068
https://devhub.checkmarx.com/cve-details/CVE-2024-4068/
https://github.com/micromatch/braces/blob/98414f9f1fabe021736e26836d8306d5de747e0d/lib/parse.js#L308
https://github.com/micromatch/braces/issues/35
https://bugzilla.suse.com/show_bug.cgi?id=1224256
Comment 1 Gabriele Sonnu 2024-05-15 11:38:05 UTC 
A vulnerable version (3.0.2) of the braces package is embedded in:

- openSUSE:Factory/cockpit-agama                                   
- SUSE:ALP:Source:Standard:1.0/cockpit-agama                       

- openSUSE:Factory/cockpit-machines                                
- SUSE:ALP:Source:Standard:1.0/cockpit-machines                    
- SUSE:SLE-15-SP3:Update:Products:MicroOS52:Update/cockpit-machines

- SUSE:SLE-15-SP4:Update:Products:Micro53:Update/cockpit-machines  
- SUSE:SLE-15-SP4:Update:Products:Micro54:Update/cockpit-machines  
- SUSE:SLE-15-SP5:Update:Products:Micro55:Update/cockpit-machines  

- openSUSE:Factory/cockpit-podman                                  
- SUSE:ALP:Source:Standard:1.0/cockpit-podman                      
- SUSE:SLE-15-SP3:Update:Products:MicroOS51:Update/cockpit-podman  
- SUSE:SLE-15-SP3:Update:Products:MicroOS52:Update/cockpit-podman  
- SUSE:SLE-15-SP4:Update:Products:Micro53:Update/cockpit-podman    
- SUSE:SLE-15-SP4:Update:Products:Micro54:Update/cockpit-podman    
- SUSE:SLE-15-SP5:Update:Products:Micro55:Update/cockpit-podman    

- openSUSE:Factory/cockpit-tukit                                   
- SUSE:ALP:Source:Standard:1.0/cockpit-tukit                       
- SUSE:SLE-15-SP3:Update:Products:MicroOS52:Update/cockpit-tukit   
- SUSE:SLE-15-SP4:Update:Products:Micro53:Update/cockpit-tukit     
- SUSE:SLE-15-SP4:Update:Products:Micro54:Update/cockpit-tukit     
- SUSE:SLE-15-SP5:Update:Products:Micro55:Update/cockpit-tukit     

- openSUSE:Factory/cockpit                                         
- SUSE:ALP:Source:Standard:1.0/cockpit                             
- SUSE:SLE-15-SP3:Update:Products:MicroOS51:Update/cockpit         
- SUSE:SLE-15-SP3:Update:Products:MicroOS52:Update/cockpit         
- SUSE:SLE-15-SP4:Update:Products:Micro53:Update/cockpit           
- SUSE:SLE-15-SP4:Update:Products:Micro54:Update/cockpit           
- SUSE:SLE-15-SP5:Update:Products:Micro55:Update/cockpit           

Upstream issue:

https://github.com/micromatch/braces/issues/35
Comment 2 Jan Zerebecki 2024-05-15 15:08:49 UTC 
I checked https://github.com/cockpit-project/cockpit/blob/main/package.json and it does not contain braces and the braces in https://build.opensuse.org/projects/openSUSE:Factory/packages/cockpit/files/package-lock.json?expand=1 is only there due to devDependencies.

If that is the same for the other packages and someone can confirm, then we can mark this as not applying to our usage, as it is only used at build time and additionally will not be exposed to user input.
Comment 3 Miika Alikirri 2024-05-16 08:35:43 UTC 
(In reply to Jan Zerebecki from comment #2)
> I checked https://github.com/cockpit-project/cockpit/blob/main/package.json
> and it does not contain braces and the braces in
> https://build.opensuse.org/projects/openSUSE:Factory/packages/cockpit/files/
> package-lock.json?expand=1 is only there due to devDependencies.
> 
> If that is the same for the other packages and someone can confirm, then we
> can mark this as not applying to our usage, as it is only used at build time
> and additionally will not be exposed to user input.

I went through all of the packages and in all of them the braces package was a sub dependency of a devDepencies.
Comment 4 Gabriele Sonnu 2024-05-16 13:44:44 UTC 
Thanks, I've updated our tracking. Nothing to do, closing.