Bugzilla – Bug 1224547
VUL-0: CVE-2024-36001: kernel: netfs: Fix the pre-flush when appending to a file in writethrough mode
Last modified: 2024-06-05 13:07:37 UTC
In the Linux kernel, the following vulnerability has been resolved: netfs: Fix the pre-flush when appending to a file in writethrough mode In netfs_perform_write(), when the file is marked NETFS_ICTX_WRITETHROUGH or O_*SYNC or RWF_*SYNC was specified, write-through caching is performed on a buffered file. When setting up for write-through, we flush any conflicting writes in the region and wait for the write to complete, failing if there's a write error to return. The issue arises if we're writing at or above the EOF position because we skip the flush and - more importantly - the wait. This becomes a problem if there's a partial folio at the end of the file that is being written out and we want to make a write to it too. Both the already-running write and the write we start both want to clear the writeback mark, but whoever is second causes a warning looking something like: ------------[ cut here ]------------ R=00000012: folio 11 is not under writeback WARNING: CPU: 34 PID: 654 at fs/netfs/write_collect.c:105 ... CPU: 34 PID: 654 Comm: kworker/u386:27 Tainted: G S ... ... Workqueue: events_unbound netfs_write_collection_worker ... RIP: 0010:netfs_writeback_lookup_folio Fix this by making the flush-and-wait unconditional. It will do nothing if there are no folios in the pagecache and will return quickly if there are no folios in the region specified. Further, move the WBC attachment above the flush call as the flush is going to attach a WBC and detach it again if it is not present - and since we need one anyway we might as well share it. References: http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-36001 https://www.cve.org/CVERecord?id=CVE-2024-36001 https://git.kernel.org/stable/c/5eaf23b2e81349f6614f88396dc468fda89fc0b9 https://git.kernel.org/stable/c/c97f59e276d4e93480f29a70accbd0d7273cf3f5 https://git.kernel.org/pub/scm/linux/security/vulns.git/plain/cve/published/2024/CVE-2024-36001.mbox
joeyli@linux-691t:/mnt/working/source_code-git/kernel-source> ./scripts/check-kernel-fix -s 0 CVE-2024-36001 c97f59e276d4 ("netfs: Fix the pre-flush when appending to a file in writethrough mode") merged v6.9-rc6~20^2 Fixes: 41d8e7673a77 ("netfs: Implement a write-through caching option") merged v6.8-rc1~27^2~2^2~4 Security fix for CVE-2024-36001 bsc#1224547 with CVSS 0 Experts candidates: lhenriques@suse.de .............................. NO ACTION NEEDED: All relevant branches contain the fix! Does not affect any branch. Reset assignee.
All done, closing.