Bug 1224986 (CVE-2021-47282) - VUL-0: CVE-2021-47282: kernel: spi: bcm2835: Fix out-of-bounds access with more than 4 slaves
Summary: VUL-0: CVE-2021-47282: kernel: spi: bcm2835: Fix out-of-bounds access with mo...
Status: RESOLVED FIXED
Alias: CVE-2021-47282
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/406914/
Whiteboard: CVSSv3.1:SUSE:CVE-2021-47282:5.5:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-22 12:35 UTC by SMASH SMASH
Modified: 2024-06-10 10:29 UTC (History)
2 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-05-22 12:35:40 UTC
In the Linux kernel, the following vulnerability has been resolved:

spi: bcm2835: Fix out-of-bounds access with more than 4 slaves

Commit 571e31fa60b3 ("spi: bcm2835: Cache CS register value for
->prepare_message()") limited the number of slaves to 3 at compile-time.
The limitation was necessitated by a statically-sized array prepare_cs[]
in the driver private data which contains a per-slave register value.

The commit sought to enforce the limitation at run-time by setting the
controller's num_chipselect to 3:  Slaves with a higher chipselect are
rejected by spi_add_device().

However the commit neglected that num_chipselect only limits the number
of *native* chipselects.  If GPIO chipselects are specified in the
device tree for more than 3 slaves, num_chipselect is silently raised by
of_spi_get_gpio_numbers() and the result are out-of-bounds accesses to
the statically-sized array prepare_cs[].

As a bandaid fix which is backportable to stable, raise the number of
allowed slaves to 24 (which "ought to be enough for anybody"), enforce
the limitation on slave ->setup and revert num_chipselect to 3 (which is
the number of native chipselects supported by the controller).
An upcoming for-next commit will allow an arbitrary number of slaves.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2021-47282
https://www.cve.org/CVERecord?id=CVE-2021-47282
https://git.kernel.org/stable/c/01415ff85a24308059e06ca3e97fd7bf75648690
https://git.kernel.org/stable/c/13817d466eb8713a1ffd254f537402f091d48444
https://git.kernel.org/stable/c/82a8ffba54d31e97582051cb56ba1f988018681e
https://git.kernel.org/stable/c/b5502580cf958b094f3b69dfe4eece90eae01fbc
https://git.kernel.org/pub/scm/linux/security/vulns.git/plain/cve/published/2021/CVE-2021-47282.mbox
Comment 2 Michal Hocko 2024-05-24 17:56:44 UTC
nothing to be done
Comment 3 Andrea Mattiazzo 2024-06-10 10:29:44 UTC
All done, closing.