Bug 1225029 (CVE-2023-52765) - VUL-0: CVE-2023-52765: kernel: mfd: qcom-spmi-pmic: Fix revid implementation
Summary: VUL-0: CVE-2023-52765: kernel: mfd: qcom-spmi-pmic: Fix revid implementation
Status: RESOLVED INVALID
Alias: CVE-2023-52765
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/407120/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-22 14:53 UTC by SMASH SMASH
Modified: 2024-07-08 15:01 UTC (History)
2 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-05-22 14:53:51 UTC
In the Linux kernel, the following vulnerability has been resolved:

mfd: qcom-spmi-pmic: Fix revid implementation

The Qualcomm SPMI PMIC revid implementation is broken in multiple ways.

First, it assumes that just because the sibling base device has been
registered that means that it is also bound to a driver, which may not
be the case (e.g. due to probe deferral or asynchronous probe). This
could trigger a NULL-pointer dereference when attempting to access the
driver data of the unbound device.

Second, it accesses driver data of a sibling device directly and without
any locking, which means that the driver data may be freed while it is
being accessed (e.g. on driver unbind).

Third, it leaks a struct device reference to the sibling device which is
looked up using the spmi_device_from_of() every time a function (child)
device is calling the revid function (e.g. on probe).

Fix this mess by reimplementing the revid lookup so that it is done only
at probe of the PMIC device; the base device fetches the revid info from
the hardware, while any secondary SPMI device fetches the information
from the base device and caches it so that it can be accessed safely
from its children. If the base device has not been probed yet then probe
of a secondary device is deferred.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2023-52765
https://git.kernel.org/pub/scm/linux/security/vulns.git/plain/cve/published/2023/CVE-2023-52765.mbox
https://git.kernel.org/stable/c/db98de0809f12b0edb9cd1be78e1ec1bfeba8f40
https://git.kernel.org/stable/c/4ce77b023d42a9f1062eecf438df1af4b4072eb2
https://git.kernel.org/stable/c/affae18838db5e6b463ee30c821385695af56dc2
https://git.kernel.org/stable/c/7b439aaa62fee474a0d84d67a25f4984467e7b95
https://www.cve.org/CVERecord?id=CVE-2023-52765
Comment 2 Carlos López 2024-05-28 09:51:43 UTC
Nothing to do, closing.