Bug 1225544 - When on Battery Power, Installation Cannot Continue Even After Plugging in Laptop
Summary: When on Battery Power, Installation Cannot Continue Even After Plugging in La...
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Aeon
Classification: openSUSE
Component: Installation (show other bugs)
Version: Current
Hardware: x86-64 Other
: P5 - None : Normal
Target Milestone: ---
Assignee: Ray Yip
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-29 02:20 UTC by Shaun McDonnell
Modified: 2024-06-18 03:54 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---
rbrown: needinfo? (sm)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shaun McDonnell 2024-05-29 02:20:31 UTC
If I start a new Aeon installation with my laptop unplugged and running on battery power, the installer correctly tells me that I need to be plugged into power before proceeding. However, even after plugging my laptop into a power source the aforementioned message cannot be dismissed. 

Software:

openSUSE Aeon RC2

Hardware:

Lenovo Thinkpad X1 Carbon 6th 
Intel Core i7
16GB Memory
1.0TB HD

Steps to Reproduce:

Start a fresh installation of Aeon via bootable USB while laptop is not connected to power. A message will appear saying that the installation cannot continue while on battery power. Plug laptop into power. Message will not be dismissed and clicking "ok" will result in message reappearing over and over again. 

Workaround:

Make sure laptop is plugged in before starting an Aeon installation. ¯\_(ツ)_/¯
Comment 1 Richard Brown 2024-06-03 11:46:33 UTC
Sounds weird compared to what I tested...but next time I'm doing a test install I'll give this a kicking to confirm your observations are recurrent

Thanks for the bug report :)
Comment 2 Richard Brown 2024-06-03 12:34:06 UTC
I'm tempted to put this down to a kernel/firmware bug with the X1 Carbon

on my Dell 5510 I'm able to recreate the following scenario.

Boot with AC plugged in
- Tik starts
- Remove AC power
- Click OK on Welcome Screen
- AC Power Adapter warning appears
- Plug in AC power
- Click Ok on AC Power Required screen
- Installation continues

So this categorically suggests that the tik code is present, correct, and accurate

HOWEVER, I'm also able to find an unrelated fun bug on the same Dell 5510

Boot with AC disconnected
- tik starts
- Click OK on Welcome Screen
- Install continues

Because the AC wasn't connected on boot the kernel/firmware never established the device nodes we use to calculate if the AC adapter is plugged in..nor does it get restablished when it's plugged in later

So..yeah.. today I learned AC power status in the kernel is weird and buggy.. I like the fact tik at least TRIES to warn users.. but I don't think we can really improve much here if the info we're getting from the hardware is bonkers.

Any objection to me closing this as WONTFIX?
Comment 3 Shaun McDonnell 2024-06-03 16:32:46 UTC
This makes sense to me and I completely agree regarding the "WONTFIX" solution. Thanks for your time!
Comment 4 Ray Yip 2024-06-04 13:47:18 UTC
I am working on an edit of that piece of code. Tik will now scan for the AC adapter and scan for a Battery charging/discharging state as well. The user will no longer be locked into that dialog and will only come as a recommendation to  be plugged in to the user.

This should cover most cases. Except for the weird outlier messed up Cmos battery giving wrong signals case.
Comment 5 Ray Yip 2024-06-09 20:10:52 UTC
I made changes to Tik, Pull Request pending merge to main branch after review:
https://github.com/sysrich/tik/pull/27
Comment 6 Ray Yip 2024-06-14 13:42:39 UTC
There was a bug in #27 pull request, as grep would automatically follow symlinks while using the '-R' flag. I have fixed this in pull request #31 https://github.com/sysrich/tik/pull/31
Comment 7 Shaun McDonnell 2024-06-14 16:26:37 UTC
If anyone would like me to test this on my X1 let me know as I am happy to help.
Comment 8 Ray Yip 2024-06-18 03:54:28 UTC
Fixed in tik pull request #31 https://github.com/sysrich/tik/pull/31