Bug 1225779 - gtest.pc injects a bogus include directory which breaks libstdc++ headers
Summary: gtest.pc injects a bogus include directory which breaks libstdc++ headers
Status: RESOLVED FIXED
Alias: None
Product: openSUSE Distribution
Classification: openSUSE
Component: Development (show other bugs)
Version: Leap 15.5
Hardware: x86-64 openSUSE Leap 15.5
: P5 - None : Major (vote)
Target Milestone: ---
Assignee: package coldpool
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-31 21:39 UTC by Bruno Pitrus
Modified: 2024-07-08 08:46 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Pitrus 2024-05-31 21:39:16 UTC
> pkg-config --cflags gtest
-DGTEST_HAS_PTHREAD=1 -lpthread -I/usr/lib64/pkgconfig/../../include

The `-I` is changed to `-isystem` by a downstream build system (Google Ninja)

When calling g++-13 with this flag on a file which includes `<cstdlib>`, i'm getting a confusing build error:

In file included from ../../v8/include/v8.h:21,
                 from ../../third_party/electron_node/src/node.h:79,
                 from ../../third_party/electron_node/src/api/async_resource.cc:1:
/usr/include/c++/13/cstdlib:79:15: fatal error: stdlib.h: No such file or directory
   79 | #include_next <stdlib.h>
      |               ^~~~~~~~~~

This is gtest-1.10.0-1.10.x86_64
The problem happens on both 15.5 and 15.6, does not happen on Tumbleweed.
Comment 1 Bruno Pitrus 2024-06-01 08:39:49 UTC
It seems a newer version with that fixed already is available: https://build.opensuse.org/package/show/openSUSE:Backports:SLE-15-SP4:Update/googletest

Not sure why OBS picked an older one.
Comment 2 Bruno Pitrus 2024-06-01 15:59:35 UTC
reopening — new googletest is available in 15.4 repo but not 15.5
Comment 3 OBSbugzilla Bot 2024-06-01 16:35:02 UTC
This is an autogenerated message for OBS integration:
This bug (1225779) was mentioned in
https://build.opensuse.org/request/show/1178070 Backports:SLE-15-SP5 / googletest
Comment 4 Robert Frohl 2024-06-07 13:51:50 UTC
(In reply to OBSbugzilla Bot from comment #3)
> This is an autogenerated message for OBS integration:
> This bug (1225779) was mentioned in
> https://build.opensuse.org/request/show/1178070 Backports:SLE-15-SP5 /
> googletest

not entirely sure what went wrong here, but the submission was empty. Trying again with the Factory version, see 1179239.
Comment 5 Robert Frohl 2024-06-07 14:06:13 UTC
(In reply to Robert Frohl from comment #4)
> (In reply to OBSbugzilla Bot from comment #3)
> > This is an autogenerated message for OBS integration:
> > This bug (1225779) was mentioned in
> > https://build.opensuse.org/request/show/1178070 Backports:SLE-15-SP5 /
> > googletest
> 
> not entirely sure what went wrong here, but the submission was empty. Trying
> again with the Factory version, see 1179239.

that also did not work, but I have a solution now
Comment 6 Robert Frohl 2024-06-25 11:35:53 UTC
(In reply to Robert Frohl from comment #5)
> (In reply to Robert Frohl from comment #4)
> > (In reply to OBSbugzilla Bot from comment #3)
> > > This is an autogenerated message for OBS integration:
> > > This bug (1225779) was mentioned in
> > > https://build.opensuse.org/request/show/1178070 Backports:SLE-15-SP5 /
> > > googletest
> > 
> > not entirely sure what went wrong here, but the submission was empty. Trying
> > again with the Factory version, see 1179239.
> 
> that also did not work, but I have a solution now

the still failing checks in OBS are a bit harder problem to solve. we will update the package in another way: the 1.10 version is coming from the SLE sources, instead of updating only the Leap version to 1.12.1 we will update the SLE sources to 1.12.1. This has the added benefit that all future Leap version will get that version by default.
Comment 7 Valentin Lefebvre 2024-07-01 08:51:52 UTC
(In reply to Robert Frohl from comment #6)
> (In reply to Robert Frohl from comment #5)
> > (In reply to Robert Frohl from comment #4)
> > > (In reply to OBSbugzilla Bot from comment #3)
> > > > This is an autogenerated message for OBS integration:
> > > > This bug (1225779) was mentioned in
> > > > https://build.opensuse.org/request/show/1178070 Backports:SLE-15-SP5 /
> > > > googletest
> > > 
> > > not entirely sure what went wrong here, but the submission was empty. Trying
> > > again with the Factory version, see 1179239.
> > 
> > that also did not work, but I have a solution now
> 
> the still failing checks in OBS are a bit harder problem to solve. we will
> update the package in another way: the 1.10 version is coming from the SLE
> sources, instead of updating only the Leap version to 1.12.1 we will update
> the SLE sources to 1.12.1. This has the added benefit that all future Leap
> version will get that version by default.

Indeed, changing SLE sources seems to be a better way to do, however, as it is an update, we must have an ECO to proceed.
Comment 8 Robert Frohl 2024-07-08 08:45:42 UTC
update just went out to Leap 15.5 and 15.6, closing the bug