Bug 1225827 (CVE-2024-36962) - VUL-0: CVE-2024-36962: kernel: net: ks8851: Queue RX packets in IRQ handler instead of disabling BHs
Summary: VUL-0: CVE-2024-36962: kernel: net: ks8851: Queue RX packets in IRQ handler i...
Status: RESOLVED FIXED
Alias: CVE-2024-36962
Product: SUSE Security Incidents
Classification: Novell Products
Component: Incidents (show other bugs)
Version: unspecified
Hardware: Other Other
: P3 - Medium : Normal
Target Milestone: ---
Assignee: Security Team bot
QA Contact: Security Team bot
URL: https://smash.suse.de/issue/408456/
Whiteboard: CVSSv3.1:SUSE:CVE-2024-36962:6.2:(AV:...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-03 11:41 UTC by SMASH SMASH
Modified: 2024-07-08 15:09 UTC (History)
2 users (show)

See Also:
Found By: Security Response Team
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SMASH SMASH 2024-06-03 11:41:40 UTC
In the Linux kernel, the following vulnerability has been resolved:

net: ks8851: Queue RX packets in IRQ handler instead of disabling BHs

Currently the driver uses local_bh_disable()/local_bh_enable() in its
IRQ handler to avoid triggering net_rx_action() softirq on exit from
netif_rx(). The net_rx_action() could trigger this driver .start_xmit
callback, which is protected by the same lock as the IRQ handler, so
calling the .start_xmit from netif_rx() from the IRQ handler critical
section protected by the lock could lead to an attempt to claim the
already claimed lock, and a hang.

The local_bh_disable()/local_bh_enable() approach works only in case
the IRQ handler is protected by a spinlock, but does not work if the
IRQ handler is protected by mutex, i.e. this works for KS8851 with
Parallel bus interface, but not for KS8851 with SPI bus interface.

Remove the BH manipulation and instead of calling netif_rx() inside
the IRQ handler code protected by the lock, queue all the received
SKBs in the IRQ handler into a queue first, and once the IRQ handler
exits the critical section protected by the lock, dequeue all the
queued SKBs and push them all into netif_rx(). At this point, it is
safe to trigger the net_rx_action() softirq, since the netif_rx()
call is outside of the lock that protects the IRQ handler.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-36962
https://git.kernel.org/pub/scm/linux/security/vulns.git/plain/cve/published/2024/CVE-2024-36962.mbox
https://git.kernel.org/stable/c/8a3ff43dcbab7c96f9e8cf2bd1049ab8d6e59545
https://git.kernel.org/stable/c/ae87f661f3c1a3134a7ed86ab69bf9f12af88993
https://git.kernel.org/stable/c/7e2901a2a9195da76111f351584bf77552a038f0
https://git.kernel.org/stable/c/e0863634bf9f7cf36291ebb5bfa2d16632f79c49
https://www.cve.org/CVERecord?id=CVE-2024-36962
Comment 1 Miroslav Franc 2024-06-06 11:14:35 UTC
The fix is in all relevant branches.  Switching back to the security team.
Comment 3 Gabriele Sonnu 2024-06-07 13:36:53 UTC
All done, closing.