Bug 1226118 - Salt "The django returner is broken and deprecated, and will be removed after 2024-01-01"
Summary: Salt "The django returner is broken and deprecated, and will be removed after...
Status: CONFIRMED
Alias: None
Product: openSUSE Distribution
Classification: openSUSE
Component: Salt (show other bugs)
Version: Leap 15.5
Hardware: Other openSUSE Leap 15.5
: P2 - High : Normal (vote)
Target Milestone: ---
Assignee: E-Mail List
QA Contact: E-mail List
URL: https://github.com/SUSE/spacewalk/iss...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-09 10:19 UTC by Georg Pfuetzenreuter
Modified: 2024-07-11 14:56 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Georg Pfuetzenreuter 2024-06-09 10:19:51 UTC
Hi,

setting

```
master_job_cache: redis
job_cache_store_endtime: True
```

in the master configuration causes some runner commands to return:

```
salt-run mine.get witch1.infra.opensuse.org roles
[ERROR   ] Exception raised when processing __virtual__ function for salt.loaded.int.returner.django_return. Module will not be loaded: The django returner is broken and deprecated, and will be removed after 2024-01-01. This warning(now exception) triggered on filename '/usr/lib/python3.6/site-packages/salt/returners/django_return.py', line number 61, is supposed to be shown until 2024-01-01. Today is 2024-06-09. Please remove the warning.
[WARNING ] salt.loaded.int.returner.django_return.__virtual__() is wrongly returning `None`. It should either return `True`, `False` or a new name. If you're the developer of the module 'django_return', please fix this.
witch1.infra.opensuse.org:
 # expected mine results show up
```

```
$ rpm -q salt-master
salt-master-3006.0-150500.4.35.1.x86_64
```

Hotpatch is changing `20240101` to `20250101` in `/usr/lib/python3.6/site-packages/salt/returners/django_return.py`.

Upstream no longer ship the Django returner at all, but the patch removing it is rather big: https://github.com/saltstack/salt/commit/3b24505b3a344cf6a0fa16428090e8ad742c5fe8. Not sure if that is feasible to backport or too breaking of a change.

Best,
Georg
Comment 1 Georg Pfuetzenreuter 2024-06-09 10:22:53 UTC
`grep -r 2024 /usr/lib/python3.6/site-packages/salt` suggests various other things self-destructed in January as well.