Bug 1227367 - vlc: libqt_plugin.so embeds current date
Summary: vlc: libqt_plugin.so embeds current date
Status: RESOLVED WORKSFORME
Alias: None
Product: openSUSE Tumbleweed
Classification: openSUSE
Component: X11 Applications (show other bugs)
Version: Current
Hardware: All openSUSE Tumbleweed
: P5 - None : Normal (vote)
Target Milestone: ---
Assignee: Dominique Leuenberger
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 1047218
  Show dependency treegraph
 
Reported: 2024-07-04 06:47 UTC by Bruno Pitrus
Modified: 2024-07-05 13:19 UTC (History)
2 users (show)

See Also:
Found By: ---
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno Pitrus 2024-07-04 06:47:10 UTC
On ix86:
[ 1527s] /usr/lib/vlc/plugins/gui/libqt_plugin.so differs in ELF sections
[ 1527s] --- old /usr/lib/vlc/plugins/gui/libqt_plugin.so (objdump)
[ 1527s] +++ new /usr/lib/vlc/plugins/gui/libqt_plugin.so (objdump)
[ 1527s] @@ -116314,8 +116314,8 @@
[ 1527s]   1c7510 56696465 6f205072 6f66696c 65005544  Video Profile.UD
[ 1527s]   1c7520 5020286c 65676163 79290049 63656361  P (legacy).Iceca
[ 1527s]   1c7530 73740042 61636b00 4e657874 0040004a  st.Back.Next.@.J
[ 1527s] - 1c7540 756c2020 33203230 32340030 333a3430  ul  3 2024.03:40
[ 1527s] - 1c7550 3a313600 20332e30 2e323120 56657469  :16. 3.0.21 Veti
[ 1527s] + 1c7540 756c2020 33203230 32340031 353a3435  ul  3 2024.15:45
[ 1527s] + 1c7550 3a343100 20332e30 2e323120 56657469  :41. 3.0.21 Veti
[ 1527s]   1c7560 6e617269 003a736f 75743d23 00647570  nari.:sout=#.dup
[ 1527s]   1c7570 6c696361 74650064 73740064 6973706c  licate.dst.displ
[ 1527s]   1c7580 61790020 3a736f75 742d616c 6c00203a  ay. :sout-all. :

On aarch64:
[ 1693s] /usr/lib64/vlc/plugins/gui/libqt_plugin.so differs in ELF sections
[ 1693s] --- old /usr/lib64/vlc/plugins/gui/libqt_plugin.so (objdump)
[ 1693s] +++ new /usr/lib64/vlc/plugins/gui/libqt_plugin.so (objdump)
[ 1693s] @@ -130664,8 +130664,8 @@
[ 1693s]   1fe7a0 4e657874 00000000 53747265 616d0000  Next....Stream..
[ 1693s]   1fe7b0 546f6f6c 62617250 726f6669 6c657300  ToolbarProfiles.
[ 1693s]   1fe7c0 50726f66 696c654e 616d6500 00000000  ProfileName.....
[ 1693s] - 1fe7d0 40000000 00000000 4a756c20 20312032  @.......Jul  1 2
[ 1693s] - 1fe7e0 30323400 00000000 31393a33 393a3033  024.....19:39:03
[ 1693s] + 1fe7d0 40000000 00000000 4a756c20 20332032  @.......Jul  3 2
[ 1693s] + 1fe7e0 30323400 00000000 30303a33 363a3334  024.....00:36:34
[ 1693s]   1fe7f0 00000000 00000000 20332e30 2e323120  ........ 3.0.21 
[ 1693s]   1fe800 56657469 6e617269 00000000 00000000  Vetinari........
[ 1693s]   1fe810 4d61696e 57696e64 6f772f4d 61696e54  MainWindow/MainT

On armv7l:
[ 5227s] /usr/lib/vlc/plugins/gui/libqt_plugin.so differs in ELF sections
[ 5227s] --- old /usr/lib/vlc/plugins/gui/libqt_plugin.so (objdump)
[ 5227s] +++ new /usr/lib/vlc/plugins/gui/libqt_plugin.so (objdump)
[ 5227s] @@ -122122,8 +122122,8 @@
[ 5227s]   1dd088 3a2f6275 74746f6e 732f706c 61796c69  :/buttons/playli
[ 5227s]   1dd098 73742f70 6c61796c 6973745f 6164642e  st/playlist_add.
[ 5227s]   1dd0a8 73766700 26496e73 74616c6c 00000000  svg.&Install....
[ 5227s] - 1dd0b8 40000000 4a756c20 20322032 30323400  @...Jul  2 2024.
[ 5227s] - 1dd0c8 30303a30 363a3038 00000000 20332e30  00:06:08.... 3.0
[ 5227s] + 1dd0b8 40000000 4a756c20 20332032 30323400  @...Jul  3 2024.
[ 5227s] + 1dd0c8 30383a30 393a3434 00000000 20332e30  08:09:44.... 3.0
[ 5227s]   1dd0d8 2e323120 56657469 6e617269 00000000  .21 Vetinari....
[ 5227s]   1dd0e8 6775692f 71742f6d 616e6167 6572732f  gui/qt/managers/
[ 5227s]   1dd0f8 6164646f 6e735f6d 616e6167 65722e63  addons_manager.c

Not observed on x86_64.
Comment 1 Bernhard Wiedemann 2024-07-04 08:10:23 UTC
Testing this is a bit tricky. With my 
https://github.com/bmwiedemann/reproducibleopensuse/ tools I used

osc co openSUSE:Factory vlc && cd $_
arch=i586 arch2=i586 oscbuildparams=--nodebugpackages \
  project=openSUSE:Slowroll repo=standard CLEAN=1 rbkt 1

The Factory vlc package cannot be built for i586 for lack of BuildRequires.

Anyway, my tests say, it builds reproducibly here.
I would appreciate a proper reproducer, otherwise this is a WORKSFORME.
Comment 2 Bruno Pitrus 2024-07-04 15:35:26 UTC
(In reply to Bernhard Wiedemann from comment #1)
> Testing this is a bit tricky. With my 
> https://github.com/bmwiedemann/reproducibleopensuse/ tools I used
> 
> osc co openSUSE:Factory vlc && cd $_
> arch=i586 arch2=i586 oscbuildparams=--nodebugpackages \
>   project=openSUSE:Slowroll repo=standard CLEAN=1 rbkt 1
> 
> The Factory vlc package cannot be built for i586 for lack of BuildRequires.
> 
> Anyway, my tests say, it builds reproducibly here.
> I would appreciate a proper reproducer, otherwise this is a WORKSFORME.

I observed this at Packman which enables more vlc features than Factory:
https://pmbs.links2linux.org/package/show/Essentials/A_tw-vlc

Unsure how to build locally against packman prjconf, but it can be seen here: https://pmbs.links2linux.org/project/prjconf/Essentials
Comment 3 Dominique Leuenberger 2024-07-04 16:51:19 UTC
the VLC Qt plugin is the same on PM as is in Factory.
VLC qt UI indeed has the DATE & TIME added to the UI (not specific to PackMan), but also the version on OBS/Factory

sudo zypper in vlc-qt-3.0.21-3.1 (Current version in Factory as of now)
vlc

Go to help/about, then click the 'version' string right under the VLC media player header (it's toggling between Version and Build Date)

Date date/time printed there is exactly the date/time of the last changelog entry (Jun 27 2024 13:54:03) which is expected and implies SOURCE_DATE_EPOCH works as intended

(I could imaging that the OBS/build script version in use is different than OBS and the SOURCE_DATE_EPOCH feature is not yet live on PM's OBS instance - but that's just a wild guess. In any case, I agree with Bernhard about WORKSFORME)
Comment 4 Bernhard Wiedemann 2024-07-05 13:19:52 UTC
I found
Essentials/A_tw-vlc # spec=vlc.spec project=Essentials repo=openSUSE_Tumbleweed \
 arch=i586 arch2=i586 oscbuildparams=--nodebugpackages CLEAN=1 rbkt

is also reproducible, except for the minor issue that rpm now embeds the expanded .spec with -j4 in the .src.rpm and binary rpms always embed the hash of the .src.rpm

So it remains a WORKSFORME.