Bug 133611 - loki_setup-1.6.1_20041219-6: dodgy looking code
Summary: loki_setup-1.6.1_20041219-6: dodgy looking code
Status: RESOLVED INVALID
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Ludwig Nussel
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-13 16:22 UTC by David Binderman
Modified: 2007-07-09 01:18 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-11-13 16:22:49 UTC
I just tried to compile package loki_setup-1.6.1_20041219-6 with a 
prerelease of version 4.1 of the GNU C compiler.

It said

gtk_ui.c:1025: warning: comparisons like X<=Y<=Z do not have their mathematical meaning

The source code is

	if (i > sizeof(install_paths) > sizeof(install_paths[0])) {

Suggest code rework.
Comment 1 Ludwig Nussel 2005-11-14 10:45:53 UTC
Feel free to send a patch upstream :-)
Comment 2 Ted Bullock 2007-07-09 01:18:29 UTC
Closing as invalid due to lack of clarity, activity and follow up from reporter.