Bug 133612 - openafs-1.3.85-3: three buglets
Summary: openafs-1.3.85-3: three buglets
Status: RESOLVED WONTFIX
Alias: None
Product: SUSE LINUX 10.0
Classification: openSUSE
Component: Basesystem (show other bugs)
Version: Final
Hardware: All SuSE Linux 10.0
: P5 - None : Minor
Target Milestone: ---
Assignee: Ales Nosek
QA Contact: E-mail List
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-13 17:11 UTC by David Binderman
Modified: 2006-09-18 06:45 UTC (History)
0 users

See Also:
Found By: Other
Services Priority:
Business Priority:
Blocker: ---
Marketing QA Status: ---
IT Deployment: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Binderman 2005-11-13 17:11:48 UTC
I just tried to compile package openafs-1.3.85-3 with a non standard version
of the GNU C compiler.

It said

1.

/usr/src/packages/BUILD/openafs-1.3.85/src/afs/UKERNEL/osi_vnodeops.c:62: warning: `return' with no value, in function returning non-void

The source code is

int
afs_inactive(struct vcache *avc, struct AFS_UCRED *acred)
{
    struct vnode *vp = AFSTOV(avc);
    if (afs_shuttingdown)
        return;

Suggest code rework.

2.

/usr/src/packages/BUILD/openafs-1.3.85/src/afs/afs_pioctl.c:640: warning: `return' with no value, in function returning non-void

The source code is

	return;

Suggest code rework.

3.

./../rxkad/rxkad_common.c:190: warning: array subscript out of range
./../rxkad/rxkad_common.c:191: warning: array subscript out of range

The source code is

	rxkad_stats->spares[8] += thr_stats->spares[8];
	rxkad_stats->spares[9] += thr_stats->spares[9];

but

    long spares[8];

so spares[8] and spares[9] do not exist. Suggest code rework.
Comment 1 Ales Nosek 2006-09-18 06:45:23 UTC
Thank you for the report. We won't fix this bug, package openafs was dropped.